Skip to content

fix(charts): circle-packing parent labels no longer hidden under children - #1101

Merged
alfredo1996 merged 1 commit into
release/1.1from
design/circlepack-label-position
Jun 20, 2026
Merged

fix(charts): circle-packing parent labels no longer hidden under children#1101
alfredo1996 merged 1 commit into
release/1.1from
design/circlepack-label-position

Conversation

@alfredo1996

Copy link
Copy Markdown
Owner

Summary

Circle-packing parent labels (e.g. "DevOps", "Backend") were drawn dead-centre, where the centred child circles cover them — they read as faint text peeking between circles.

Now parent labels are emitted as a separate, later data pass so they draw ON TOP of all circles, as a small dark top-rim pill (white text) that stays readable over any fill or child circle. Leaf labels keep their centred per-cell contrast text.

Before / after

circle-packing labels

Tests

  • Parent-label pill (kind=1) renders as a standalone top-rim text element; label entries are emitted after all circle entries (z-order on top); leaf contrast unchanged. tsc · chart suite · lint clean.

Part of the v1.1 "vibrant / less-AI" chart review (flagged follow-up from #1095/#1098).

…dren

Parent (non-leaf) labels were drawn dead-centre, where the centred child
circles cover them — they read as faint text peeking between circles. Now
parent labels are emitted as a separate, later data pass so they draw ON TOP
of all circles, as a small dark top-rim pill (white text) that stays readable
over any fill or child. Leaf labels keep centred per-cell contrast text.

tsc + chart suite + lint clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@alfredo1996 alfredo1996 added area:charts Chart rendering area:design Visual design, tokens, typography pkg:component UI component library labels Jun 19, 2026
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@alfredo1996, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 23 minutes and 5 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bee0cb7e-bee2-42da-a87d-007e0d97a45f

📥 Commits

Reviewing files that changed from the base of the PR and between 7f7441c and f1fdcbd.

⛔ Files ignored due to path filters (1)
  • claude_code_docs/component-review/img/comp-circlepack-labels.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • component/src/charts/__tests__/circle-packing-chart.test.tsx
  • component/src/charts/circle-packing-chart.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch design/circlepack-label-position

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@alfredo1996
alfredo1996 merged commit 9ace1b9 into release/1.1 Jun 20, 2026
15 checks passed
@alfredo1996
alfredo1996 deleted the design/circlepack-label-position branch June 20, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:charts Chart rendering area:design Visual design, tokens, typography pkg:component UI component library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants