fix(charts): align circle-packing/graph/gauge to the citrine brand palette - #1097
Closed
alfredo1996 wants to merge 1 commit into
Closed
fix(charts): align circle-packing/graph/gauge to the citrine brand palette#1097alfredo1996 wants to merge 1 commit into
alfredo1996 wants to merge 1 commit into
Conversation
…lette These three charts hardcoded off-brand palettes — the stock ECharts palette (circle-packing DEPTH_COLORS, gauge default #5470c6) and a Tableau-10 palette (graph node labels) — which read as a generic "default chart" look. Point them all at the shared citrine palette (CITRINE_LIGHT/DARK), theme-aware: - circle-packing: depth colors from citrine (+ neutral root fill); per-cell contrast labels already handle readability on the new fills. - graph: node-label palette = citrine light/dark. - gauge: default progress arc = citrine accent, not stock blue. Tests assert citrine (not stock) colors. tsc + chart suite + lint clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alfredo1996
added
area:charts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three charts hardcoded off-brand palettes that read as a generic "stock chart" look — the opposite of the vibrant, on-brand direction:
#5470c6,#91cc75, …) by depth.#5470c6(stock ECharts blue).This points all three at the shared citrine palette (
CITRINE_LIGHT/CITRINE_DARK), theme-aware, so every chart reads as one vibrant system. Circle-packing's per-cell contrast labels (from #1095) keep labels readable on the new fills.Before / after
Circle-packing — stock blue/green → citrine amber/teal
Graph — Tableau palette → citrine
Gauge default arc is now the citrine amber accent (was stock blue).
Tests
#5470c6) colors on gauge default + circle-packing depth fills.tsc· chart suite (545) · lint all clean.Note
design/chart-label-readability) so the contrast labels + citrine fills compose without a readability regression. Retarget torelease/1.1once fix(charts): readable labels on colored fills (treemap/sunburst/circle-packing) #1095 merges.