Repository navigation
Match URGENT's SNR definition and 4 kHz band limit - #163
Merged
Merged
Conversation
SNR is now measured over non-silent frames, ported from ESPnet's detect_non_silence (threshold 0.01, 1024/512 frames), the definition URGENT 2024 simulates with. Whole-clip power skewed each mix by however much silence the speech or noise clip carried. A band limit whose cutoff is half a standard sample rate (4 kHz) now resamples down to 8 kHz and back with resample_poly, one of URGENT's filter options, instead of an FFT brickwall. Other cutoffs keep the brickwall. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mix_at_snrmeasures speech and noise power over non-silent frames only, a port of ESPnet'sdetect_non_silence(the function URGENT 2024's simulation uses). Whole-clip power skewed each clip's real SNR by however much silence it carried.resample_poly(one of URGENT's resampler options) instead of an FFT brickwall, so the transition band and aliasing look like real narrowband audio. 5.5 kHz and 7 kHz cutoffs keep the brickwall.Test plan
tests/test_train_augment.py: non-silence detection, active-power SNR on gappy speech, resampled band limit keeps the passband and removes energy above 4 kHz (35 passed)ta dev check,ta dev test🤖 Generated with Claude Code