fix: remove obsolete vendor-prefixed and IE-specific CSS#3313
Open
lekhmanrus wants to merge 1 commit intoakveo:masterfrom
Open
fix: remove obsolete vendor-prefixed and IE-specific CSS#3313lekhmanrus wants to merge 1 commit intoakveo:masterfrom
lekhmanrus wants to merge 1 commit intoakveo:masterfrom
Conversation
Remove vendor-prefixed CSS that is no longer needed for modern browsers: - Remove `-webkit-`, `-moz-`, `-o-` prefixed `@keyframes` and `animation` properties from the keyframes/animation mixins - Replace `@-webkit-keyframes` with standard `@keyframes` in live-example-block - Replace `-webkit-transform` with standard `transform` in keyframes - Remove `-webkit-overflow-scrolling: touch` (deprecated since iOS 13) - Remove `-webkit-transform: translate3d(0,0,0)` iOS GPU hack Remove IE-specific CSS (IE support dropped in Nebular v9.0.0): - Remove `-ms-flex: 1 1 auto` fallbacks from layout, card, accordion, tabset, and modal components - Remove `::-ms-clear`, `::-ms-expand` pseudo-elements - Remove `::-ms-thumb`, `::-ms-track`, `:-ms-input-placeholder` from SCSS selector mixins - Remove IE scrollbar properties (`scrollbar-face-color`, `scrollbar-track-color`) - Remove IE6/IE7 `clip: rect()` fallbacks (keep standard comma-separated syntax) The vendor-prefixed `@keyframes` rules also caused build warnings with Angular's critical CSS inliner (beasties), which fails to parse percentage selectors inside `-moz-keyframes` and `-o-keyframes` at-rules. Signed-off-by: Ruslan Lekhman <lekhman112@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Remove vendor-prefixed CSS that is no longer needed for modern browsers:
-webkit-,-moz-,-o-prefixed@keyframesandanimationproperties from the keyframes/animation mixins@-webkit-keyframeswith standard@keyframesin live-example-block-webkit-transformwith standardtransformin keyframes-webkit-overflow-scrolling: touch(deprecated since iOS 13)-webkit-transform: translate3d(0,0,0)iOS GPU hackRemove IE-specific CSS (IE support dropped in Nebular v9.0.0):
-ms-flex: 1 1 autofallbacks from layout, card, accordion, tabset, and modal components::-ms-clear,::-ms-expandpseudo-elements::-ms-thumb,::-ms-track,:-ms-input-placeholderfrom SCSS selector mixinsscrollbar-face-color,scrollbar-track-color)clip: rect()fallbacks (keep standard comma-separated syntax)The vendor-prefixed
@keyframesrules also caused build warnings with Angular's critical CSS inliner (beasties), which fails to parse percentage selectors inside-moz-keyframesand-o-keyframesat-rules.