feat(upgradepipeline): add upgrade pipeline step support#1178
Open
ndk wants to merge 2 commits into
Open
Conversation
ndk
force-pushed
the
akarpov/nex-2532/upgrade-pipeline-steps
branch
from
42fed97 to
d7f3744
Compare
vmyroslav
reviewed
May 22, 2026
| } | ||
|
|
||
| func (r *UpgradePipelineStepController) lookupStep(ctx context.Context, cr *v1alpha1.UpgradePipelineStep) (*upgradepipeline.StepOut, error) { | ||
| out, err := r.avnGen.UpgradePipelineStepList(ctx, cr.Spec.OrganizationID) |
Contributor
There was a problem hiding this comment.
Based on the response type:
type UpgradePipelineStepListOut struct {
First *string `json:"first,omitempty"` // First page
Last *string `json:"last,omitempty"` // Last page
Next *string `json:"next,omitempty"` // Next page
Prev *string `json:"prev,omitempty"` // Previous page
Steps []StepOut `json:"steps"`
TotalCount *int `json:"total_count,omitempty"` // Total number of results
}I assume that the pagination is possible, so we need to handle it.
|
|
||
| func (*UpgradePipelineStepController) applyStatus(cr *v1alpha1.UpgradePipelineStep, step upgradepipeline.StepOut) { | ||
| cr.Status.ID = step.StepId | ||
| cr.Status.LastValidation = &v1alpha1.UpgradePipelineStepLastValidationStatus{ |
Contributor
There was a problem hiding this comment.
I noticed in some of our CRD statuses we set many empty fields. Does it make sense to check that fields are not-empty? WDYT?
ndk
force-pushed
the
akarpov/nex-2532/upgrade-pipeline-steps
branch
from
d7f3744 to
73e01e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: NEX-2532
Add
UpgradePipelineStepfor upgrade pipeline steps.I'm not sure preconditions add much value here. Kubernetes reconciliation is eventually consistent, so temporary failures caused by a service not being ready would be retried anyway and should work once the dependency is available.
My main concern is that this could block adoption. It also gets less clear when the services aren't managed by the operator.