Skip to content

fix(dca): validated configurable fee; fix(defi-portfolio-scanner): LTV threshold scale consistency (dormant until ltv is populated) #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
biwasxyz merged 3 commits into from
Jul 16, 2026
Merged

fix(dca): validated configurable fee; fix(defi-portfolio-scanner): LTV threshold scale consistency (dormant until ltv is populated) #410

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6743287
fix(dca, defi-portfolio-scanner): configurable dca fee (stuck-nonce r…
Jul 15, 2026
6c3ab58
review(arc0btc): named LTV threshold constants; document that the ris…
Jul 15, 2026
203aa9e
review(biwasxyz): validated DCA fee parsing (+cap), align balance pre…
Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dca/dca.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,11 @@ async function executeDirectSwap(opts: {
network,
senderKey: opts.stxPrivateKey,
anchorMode: AnchorMode.Any,
fee: 5000n,
// 2026-07-15 field audit F-14: an underpriced hardcoded fee is a
// stuck-head-nonce seed (one stuck tx stalls every later tx from the
// signer). Configurable via DCA_FEE_USTX; default raised to match
// field-tested contract-call fees.
fee: BigInt(process.env.DCA_FEE_USTX ?? "50000"),
});

const broadcastRes = await broadcastTransaction({ transaction: tx, network });
Expand Down
8 changes: 6 additions & 2 deletions defi-portfolio-scanner/defi-portfolio-scanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,14 +731,18 @@ function computeRiskScore(scanData: ScanData): {
// 3. Zest LTV risk
for (const pos of protocols.zest.positions) {
if (pos.ltv !== null) {
if (pos.ltv > 85) {
// Scale contract (2026-07-15 field audit F-13): ltv is a FRACTION in
// [0, 1] — the display below multiplies by 100. The previous thresholds
// compared raw ltv > 85 / > 70, which a fractional value can never
// exceed, so the liquidation-risk flags could never fire.
if (pos.ltv > 0.85) {
score += 30;
factors.push({
factor: "zest-ltv-critical",
severity: "critical",
detail: `Zest position ${pos.asset} has LTV ${(pos.ltv * 100).toFixed(1)}% — liquidation risk imminent.`,
});
} else if (pos.ltv > 70) {
} else if (pos.ltv > 0.70) {
score += 15;
factors.push({
factor: "zest-ltv-warning",
Expand Down
Loading