Skip to content

Changed toString() to Object.prototype.toString() #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nagman wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Changed toString() to Object.prototype.toString() #1

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
025562c
Changed toString() to Object.prototype.toString()
nagman Jul 26, 2018
3ad58a2
Update index.js
zbitname Jul 26, 2018
3b01f9e
Update index.js
zbitname Jul 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* @return {Boolean}
*/
function isObject(value) {
return value && value.toString() === '[object Object]';
return value && Object.prototype.toString(value) === '[object Object]';

@zbitname zbitname Jul 26, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object.prototype.toString() always return [object Object] and it's incorrect.

}

/**
Expand Down