Repository navigation
Verify LLM service callers and typed sampler certificate delegation - #16358
Merged
agentydragon merged 2 commits intoNov 14, 2026
Merged
Conversation
Contributor
Visual review for
|
agentydragon-agent
force-pushed
the
agent/service-svid-llm
branch
4 times, most recently
from
November 14, 2026 07:50
686efec to
35451ee
Compare
agentydragon-agent
force-pushed
the
agent/service-svid-llm
branch
from
November 14, 2026 08:13
35451ee to
958c941
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add exact service SVID allowlists for LLM ModelConfig reads and Central Sampler inference delegation. The sampler must supply a typed effective Identity and Session envelope; live UID verification and the Identity’s egress grants remain authoritative. A service certificate carries neither a synthetic account nor Pod proof, and failed certificate verification cannot select a bearer fallback.
Rebased PR head:
958c9417080866e425fa72e8195c479f0f4f28c3. This PR targets devel because cross-fork native stacks are unsupported.Stage 3 only. Deliberately excludes production settings, the sampler’s
auth.mode: agentplane_ingresscaller switch, other caller TLS changes, and TokenReview/RBAC removal. Those wait for receiver image pins. Staging’s existing bearer mode continues during this stage. The overview includes optional service edges.Validation: pre-commit and commit hooks passed. Isolated
bbr test //agentplane/llm_ingress:ingress_test //agentplane/llm_ingress:settingspassed (real TLS peer/delegation tests, exact caller denial, effective Identity/Session, stale UID and bearer ambiguity). Deployment suite coverage is recorded below.Rollback: revert before enabling service callers; after caller migration, first restore compatible caller images/settings. Existing bearer/workload admission remains available at this stage. Check ModelConfig discovery and ordinary inference after rollout.
Isolated
bbr test //agentplane/llm_ingress:ingress_test //agentplane/llm_ingress:settingspassed (https://app.buildbuddy.io/invocation/ff86e46a-7863-4843-a78a-19815e3c2aa1). Deployment suitebbr test //agentplane/system_tests/suites/mcp:test_servicespassed (https://app.buildbuddy.io/invocation/16dc4905-93cc-4c45-bc49-9fb33e486584).Rollout gate: no new certificate-path or service-allowlist manifest setting until #16359 merges and the receiver images are pinned.
Inactive service defaults are omitted from rendered settings.
bbr test //agentplane/llm_ingress:settings //cluster/cdk8s:test_generate_manifestspassed (https://app.buildbuddy.io/invocation/19584d67-2eb9-41cc-9e33-fbfdb3960e32).Questions for Claude
Before stage 4, verify staging central Sessions retain execution Identity name and UID required by typed LLM delegation. No fallback to bearer is permitted if that proof is absent.
Rebased after #16354 and #16357 merged; the only conflict was in
system_overview.md. Both merged diagrams and the LLM authentication edge are preserved. Scoped pre-commit andgit diff --checkpassed; receiver code is unchanged by this rebase.