Skip to content

agentplane: make sampler resident runtime owner-private - #16232

Open
agentydragon wants to merge 1 commit into
codex/agentplane-sampler-execution-batch4from
codex/agentplane-sampler-resident-batch4
Open

agentydragon wants to merge 1 commit into
codex/agentplane-sampler-execution-batch4from
codex/agentplane-sampler-resident-batch4

Conversation

@agentydragon

@agentydragon agentydragon commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Move the sampler's remaining resident scheduling, Code Mode binding, provider I/O and turn/drain orchestration into internal/residentruntime, with its tests. The command composes concrete owners; RPC keeps its concrete Runtime pointer. No Go implementation or forwarding package remains at the service root.

All 25 moved Go files differ only in their package declaration and the primary constructor name (residentruntime.New). Lease claim/renew/release, permits, wakeup reconciliation, provider retries, interrupts, effect settlement and shutdown order are unchanged. SQL and migrations remain Store-owned; Runner transport/effects remain Executor-owned; admission and streaming remain RPC-owned.

Update every import, BUILD target, active source reference and verification instruction together. Test registration retains race mode and real PostgreSQL/host fixtures. Parent review confirms all 141 production SQL literals and all 290 existing sampler test functions remain, and every tracked sampler test file belongs to a go_test.

Validation: command service image builds on RBE; formatting, Gazelle and commit hooks pass. All four resident-runtime and RPC unit/integration suites pass on the combined Store/RPC/Executor tree; hosted CI checks the published head separately.

Proposed, ready successor to #16230 in native stack #16208. This completes the four sampler ownership extractions after its content/migration leaves. Lifecycle redesign, privileged-backend authentication standardization and protobuf wire-name/filesystem alignment remain separate planned work.

@agentydragon agentydragon added the proposed Concrete implementation proposed for review; not approved for automatic merge label Nov 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proposed Concrete implementation proposed for review; not approved for automatic merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant