Repository navigation
agentplane: make sampler resident runtime owner-private - #16232
Open
agentydragon wants to merge 1 commit into
Open
agentydragon wants to merge 1 commit into
agentydragon wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the sampler's remaining resident scheduling, Code Mode binding, provider I/O and turn/drain orchestration into
internal/residentruntime, with its tests. The command composes concrete owners; RPC keeps its concrete Runtime pointer. No Go implementation or forwarding package remains at the service root.All 25 moved Go files differ only in their package declaration and the primary constructor name (
residentruntime.New). Lease claim/renew/release, permits, wakeup reconciliation, provider retries, interrupts, effect settlement and shutdown order are unchanged. SQL and migrations remain Store-owned; Runner transport/effects remain Executor-owned; admission and streaming remain RPC-owned.Update every import, BUILD target, active source reference and verification instruction together. Test registration retains race mode and real PostgreSQL/host fixtures. Parent review confirms all 141 production SQL literals and all 290 existing sampler test functions remain, and every tracked sampler test file belongs to a go_test.
Validation: command service image builds on RBE; formatting, Gazelle and commit hooks pass. All four resident-runtime and RPC unit/integration suites pass on the combined Store/RPC/Executor tree; hosted CI checks the published head separately.
80ebb5325f.Proposed, ready successor to #16230 in native stack #16208. This completes the four sampler ownership extractions after its content/migration leaves. Lifecycle redesign, privileged-backend authentication standardization and protobuf wire-name/filesystem alignment remain separate planned work.