Repository navigation
agentplane: replace test Client SSE with typed History reads - #16223
Open
agentydragon wants to merge 1 commit into
Open
agentydragon wants to merge 1 commit into
agentydragon wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the test-only
Client.eventsSSE parser with typedReadSessionEventspages through the existing authenticated App History facade. A shared reader validates cursor coverage, applies settlement/removal corrections, and retries only idempotent History reads during App outages.Migrate the system-test Agent, setup, native-artifact, storage, and suspend/resume consumers while preserving command-admission, completed-turn/setup, correction, and raw archive-watermark behavior. Record this first slice in the task DAG.
The direct HTTP SSE tests and consumers, App SSE route, and route-specific bridge remain for the separately scoped retirement slice. Native History clients remain gRPC; this adds no reader grant or browser-credential forwarding.
Validation
direnv exec . bbr test //agentplane/app/testing:test_client //agentplane/system_tests/driver:test_agentdirenv exec . bbr build //agentplane/app/testing:client //agentplane/app/testing:history_reads //agentplane/app/testing:test_client //agentplane/system_tests/driver:agent //agentplane/system_tests/driver:native_artifacts //agentplane/system_tests/driver:session_setup //agentplane/system_tests/driver:test_agent //agentplane/system_tests/scenarios:storage //agentplane/system_tests/scenarios:suspend_resumedirenv exec . bb run //devinfra:gazelledirenv exec . pre-commit run --filesfor all changed files