Skip to content

Drop unused MCP edge inputs from Pod, VM and Firecracker tests - #16220

Merged
agentydragon merged 3 commits into
develfrom
fix/agentplane-unused-mcp-ci-inputs
Nov 13, 2026
Merged

agentydragon merged 3 commits into
develfrom
fix/agentplane-unused-mcp-ci-inputs

Conversation

@agentydragon

Copy link
Copy Markdown
Owner

Pod scenarios, VM and Firecracker fixtures render and import MCP-edge even though their scenarios do not use external Connections. This gives MCP-edge source changes an unnecessary dependency path into three costly deployment suites.

Give those fixtures a NO_MCP_EDGE profile and exclude its OCI image from their declared inputs. Keep Actions, all retained rendered resources, scenario bodies and test frequency. Default, Dispatcher, deletion, real-model and MCP acceptance retain the full service. Renderer tests require every retained object to match the full profile and verify that default/MCP fixtures still include the edge.

Normal hooks pass. Required PR CI validates this independent backport. On architecture source 91f72591a1, the unchanged Pod/full-VM/both Firecracker cases passed required CI; a source-pinned synthetic selector comparison selected 15 rather than 18 tests, removing exactly these three suites while retaining MCP acceptance. That is graph evidence for one footprint, not a measured CI-time saving or a representative workload frequency.

This leaves the architecture branch's native contracts, case concurrency, Secret cadence, reconnect-budget and candidate split experiments in #16102; none is needed for this input cut. Revert this profile change to restore full fixture/image ownership if a retained scenario acquires an MCP dependency.

@agentydragon
agentydragon enabled auto-merge (squash) November 13, 2026 12:07
@agentydragon
agentydragon merged commit f2a98e9 into devel Nov 13, 2026
11 checks passed
@agentydragon
agentydragon deleted the fix/agentplane-unused-mcp-ci-inputs branch November 13, 2026 12:18
@github-actions

Copy link
Copy Markdown
Contributor

Visual review for 7bd0a003

Request a manual rerun from the CI run page.

56 Bazel test targets produced visual artifacts · 0 modified, 5 new, 0 removed, 1420 unchanged, 0 unstable. Open visual review.

Changed tests

//cluster/cdk8s/cdviz:test_ingestion_visual — incomplete or non-comparable; 5 new · CDviz CI dashboard (all-runs) · request rerun
  • ⚠️ Screenshot records disagree on the target title.
all-runs — new · link

all-runs

feedback — new · link

feedback

feedback-head-clock — new · link

feedback-head-clock

feedback-week — new · link

feedback-week

filtered — new · link

filtered

55 unchanged targets

agentydragon added a commit that referenced this pull request Nov 13, 2026
Records the source663 milestone: real TokenReview admission negatives
and History outage/catch-up in the native Sampler test; six selected
targets pass 25 Python JUnit cases plus Go startup, and all required
checks pass in 10m01s from workflow creation. Earlier source91f
observations remain explicitly historical; no matched speedup or
gate/frequency promotion is claimed.

Adds reviewed evidence for merged devel PRs #16218/#16220, the
managed-VM kernel fault and automatic VM-suite re-execution tracked in
#16222, actual Bazel profile limits, read-only KVM colocation
feasibility, and the partial historical replay with both failed attempts
preserved. No live infrastructure change.

Validation: final assets passed RBE browser validation at
18b344e4-e593-4d13-bca2-b9bf3715430c: four desktop/mobile light/dark
cases, 76 screenshots, live OS theme switching, expanded
selectors/plan/cohort, zero errors or skips. Four representative final
images inspected; all 11 packaged/browser-fetched/final asset SHA256
values match. Only the architecture report namespace changes; shared
navigation and assets are preserved. Live publication will be verified
separately after merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant