Skip to content

agentplane: separate Dispatcher terminal notice encoding and assembly - #16212

Open
agentydragon wants to merge 1 commit into
codex/agentplane-runnercontrol-batch4from
codex/agentplane-terminalnotice-batch4
Open

agentydragon wants to merge 1 commit into
codex/agentplane-runnercontrol-batch4from
codex/agentplane-terminalnotice-batch4

Conversation

@agentydragon

Copy link
Copy Markdown
Owner

Dispatcher terminal-notice serialization and multipart reassembly currently share files with SQL deletion and PostgreSQL watch lifecycle code. Extract the pure notification protocol into dispatcher/internal/terminalnotice, with its terminal snapshot value and bounded assembler.

Store.EndSandbox still publishes notices in the same deletion transaction; WatchHub still owns LISTEN, subscriber failure, reconnect/reset, and incomplete-event expiry. Preserve the payload/protobuf bytes, identity checks, size/part limits, duplicate handling, and race protection. Existing multipart, reverse-order, watcher, and Sandbox-deletion integration assertions remain intact.

Stacked above the runner-control adapter extraction in native stack #16208. RBE passed Dispatcher store integration and watch tests (https://app.buildbuddy.io/invocation/c06c07d5-3fd1-4b36-a738-6da2d037516c) and built the Gateway executable. Scoped hooks passed; hosted CI checks the integrated layer.

@agentydragon agentydragon added the proposed Concrete implementation proposed for review; not approved for automatic merge label Nov 13, 2026
@agentydragon
agentydragon force-pushed the codex/agentplane-terminalnotice-batch4 branch from e2effec to c6608fd Compare November 13, 2026 11:37
@agentydragon
agentydragon enabled stacked auto-merge (squash) November 13, 2026 11:38
@agentydragon
agentydragon force-pushed the codex/agentplane-terminalnotice-batch4 branch from c6608fd to 16a5bc0 Compare November 13, 2026 11:44
@agentydragon
agentydragon force-pushed the codex/agentplane-terminalnotice-batch4 branch from 16a5bc0 to 34bc4b1 Compare November 13, 2026 11:52
@agentydragon
agentydragon disabled stacked auto-merge November 13, 2026 11:54
@agentydragon
agentydragon force-pushed the codex/agentplane-terminalnotice-batch4 branch from 34bc4b1 to ed7e3d1 Compare November 13, 2026 11:54
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Visual review for 25a1fa4a

Request a manual rerun from the CI run page.

Warning

1 target used the latest devel baseline (5bce8ae5) because the PR base published none. Diffs there may include devel drift, not just this PR's changes.

No visual changes among the 1 affected Bazel test target. Open visual review.

@agentydragon
agentydragon force-pushed the codex/agentplane-terminalnotice-batch4 branch from ed7e3d1 to 25a1fa4 Compare November 13, 2026 12:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proposed Concrete implementation proposed for review; not approved for automatic merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant