M26: Cross-platform parity

.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [macos-latest, ubuntu-latest, windows-latest]
+        os: [macos-14, ubuntu-22.04, windows-latest]
     steps:
       - uses: actions/checkout@v4
 
@@ -25,9 +25,11 @@ jobs:
           components: clippy, rustfmt
 
       - uses: Swatinem/rust-cache@v2
+        with:
+          key: ${{ matrix.os }}
 
       - name: Install Tauri Linux deps
-        if: matrix.os == 'ubuntu-latest'
+        if: matrix.os == 'ubuntu-22.04'
         run: |
           sudo apt-get update
           sudo apt-get install -y \
@@ -57,7 +59,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [macos-latest, ubuntu-latest, windows-latest]
+        os: [macos-14, ubuntu-22.04, windows-latest]
     steps:
       - uses: actions/checkout@v4
 
@@ -97,13 +99,161 @@ jobs:
           path: apps/desktop/playwright-report
           if-no-files-found: ignore
 
+      - name: Build frontend (vite)
+        run: pnpm -F desktop build:vite
+
+      - name: Capture Lighthouse baseline
+        run: node apps/desktop/scripts/capture-lighthouse-baseline.mjs
+
+      - name: Upload Lighthouse baseline
+        uses: actions/upload-artifact@v4
+        with:
+          name: lighthouse-baseline-${{ matrix.os }}
+          path: apps/desktop/tests/browser/__snapshots__/lighthouse-baseline.json
+          if-no-files-found: error
+
   deny:
     name: cargo-deny
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: EmbarkStudios/cargo-deny-action@v2
 
+  e2e:
+    name: e2e (${{ matrix.os }})
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-22.04, windows-latest]
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: dtolnay/rust-toolchain@stable
+
+      - uses: Swatinem/rust-cache@v2
+        with:
+          key: e2e-${{ matrix.os }}
+
+      - uses: pnpm/action-setup@v4
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version: "24"
+          cache: pnpm
+
+      - name: Install Tauri Linux deps
+        if: matrix.os == 'ubuntu-22.04'
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y \
+            libwebkit2gtk-4.1-dev \
+            libgtk-3-dev \
+            libayatana-appindicator3-dev \
+            librsvg2-dev \
+            libsoup-3.0-dev \
+            libjavascriptcoregtk-4.1-dev \
+            libxdo-dev \
+            xvfb \
+            webkit2gtk-driver
+
+      - name: Install tauri-driver
+        run: cargo install tauri-driver --locked
+
+      - name: Align msedgedriver to installed WebView2 (Windows)
+        # Tauri 2 e2e on Windows fails with `DevToolsActivePort file doesn't exist`
+        # when the runner's msedgedriver drifts from the installed WebView2 build.
+        # msedgedriver-tool downloads a matching driver and puts it on PATH.
+        # https://v2.tauri.app/develop/tests/webdriver/ci/
+        if: matrix.os == 'windows-latest'
+        shell: pwsh
+        run: |
+          cargo install --git https://github.com/chippers/msedgedriver-tool --locked
+          msedgedriver-tool
+          # msedgedriver-tool writes the matched driver into the current dir;
+          # prepend it to PATH so tauri-driver picks it up over the bundled one.
+          "$pwd" | Out-File -FilePath $env:GITHUB_PATH -Append -Encoding utf8
+
+      - name: Install frontend deps
+        run: pnpm install --frozen-lockfile
+
+      - name: Build script-shell sidecar
+        run: cargo build -p ripley-guard --bin ripley-script-shell --release
+
+      - name: Stage sidecar for Tauri bundler
+        shell: bash
+        run: |
+          mkdir -p apps/desktop/src-tauri/binaries
+          TRIPLE=$(rustc -vV | sed -n 's/^host: //p')
+          if [ "${{ runner.os }}" = "Windows" ]; then
+            cp "target/release/ripley-script-shell.exe" \
+               "apps/desktop/src-tauri/binaries/ripley-script-shell-$TRIPLE.exe"
+          else
+            cp "target/release/ripley-script-shell" \
+               "apps/desktop/src-tauri/binaries/ripley-script-shell-$TRIPLE"
+          fi
+
+      - name: Build frontend (vite)
+        run: pnpm -F desktop build:vite
+
+      - name: Build desktop app + guard-bench
+        run: cargo build -p ripley-desktop --release --features custom-protocol
+
+      - name: Probe native WebDriver (Linux)
+        if: matrix.os == 'ubuntu-22.04'
+        run: |
+          which WebKitWebDriver || true
+          WebKitWebDriver --version || true
+          which tauri-driver
+          tauri-driver --help | head -30 || true
+
+      - name: Run WebdriverIO e2e (Linux, under xvfb)
+        if: matrix.os == 'ubuntu-22.04'
+        env:
+          RIPLEY_SKIP_BUILD: "1"
+          RIPLEY_E2E: "1"
+        # Give xvfb a real-ish screen — Tauri's monitor APIs crash on the
+        # default 1280x1024x8 (tauri-apps/tauri#7376).
+        run: xvfb-run -a --server-args="-screen 0 1920x1080x24" pnpm -F desktop test:e2e
+
+      - name: Kill stale drivers (Windows)
+        if: matrix.os == 'windows-latest'
+        shell: pwsh
+        # Prevents tauri-apps/tauri#8610-class userdata-lock crashes between runs.
+        run: |
+          Get-Process msedgedriver -ErrorAction SilentlyContinue | Stop-Process -Force -ErrorAction SilentlyContinue
+          Get-Process tauri-driver -ErrorAction SilentlyContinue | Stop-Process -Force -ErrorAction SilentlyContinue
+
+      - name: Probe ripley-desktop standalone start (Windows)
+        # Distinguishes "binary itself crashes" from "msedgedriver protocol gap".
+        # Launches the binary, waits 5s, then kills it. Non-zero exit captured.
+        if: matrix.os == 'windows-latest'
+        shell: pwsh
+        env:
+          RIPLEY_E2E: "1"
+        run: |
+          $bin = "target/release/ripley-desktop.exe"
+          if (-not (Test-Path $bin)) { Write-Error "missing $bin"; exit 1 }
+          $p = Start-Process -FilePath $bin -PassThru -RedirectStandardOutput desktop-probe.out -RedirectStandardError desktop-probe.err
+          Start-Sleep -Seconds 5
+          if ($p.HasExited) {
+            Write-Host "ripley-desktop.exe exited unexpectedly with code $($p.ExitCode)"
+            Get-Content desktop-probe.out -ErrorAction SilentlyContinue
+            Get-Content desktop-probe.err -ErrorAction SilentlyContinue
+            exit 1
+          }
+          Write-Host "ripley-desktop.exe still running after 5s — standalone start OK"
+          Stop-Process -Id $p.Id -Force
+          Get-Content desktop-probe.out -ErrorAction SilentlyContinue
+          Get-Content desktop-probe.err -ErrorAction SilentlyContinue
+
+      - name: Run WebdriverIO e2e (Windows)
+        if: matrix.os == 'windows-latest'
+        env:
+          RIPLEY_SKIP_BUILD: "1"
+          RIPLEY_E2E: "1"
+        run: pnpm -F desktop test:e2e
+
   release:
     name: release-${{ matrix.target }}
     if: github.ref == 'refs/heads/main'
@@ -114,11 +264,11 @@ jobs:
       matrix:
         include:
           - target: x86_64-apple-darwin
-            os: macos-latest
+            os: macos-14
           - target: aarch64-apple-darwin
-            os: macos-latest
+            os: macos-14
           - target: x86_64-unknown-linux-gnu
-            os: ubuntu-latest
+            os: ubuntu-22.04
           - target: x86_64-pc-windows-msvc
             os: windows-latest
     steps:
@@ -129,9 +279,11 @@ jobs:
           targets: ${{ matrix.target }}
 
       - uses: Swatinem/rust-cache@v2
+        with:
+          key: release-${{ matrix.target }}
 
       - name: Install Tauri Linux deps
-        if: matrix.os == 'ubuntu-latest'
+        if: matrix.os == 'ubuntu-22.04'
         run: |
           sudo apt-get update
           sudo apt-get install -y \
@@ -143,12 +295,56 @@ jobs:
             libjavascriptcoregtk-4.1-dev \
             libxdo-dev
 
-      - name: Build release
-        run: cargo build --workspace --release --target ${{ matrix.target }}
+      - uses: pnpm/action-setup@v4
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version: "24"
+          cache: pnpm
+
+      - name: Install frontend deps
+        run: pnpm install --frozen-lockfile
+
+      - name: Build script-shell sidecar
+        run: cargo build -p ripley-guard --bin ripley-script-shell --release --target ${{ matrix.target }}
+
+      - name: Stage sidecar for Tauri bundler
+        shell: bash
+        run: |
+          mkdir -p apps/desktop/src-tauri/binaries
+          if [ "${{ runner.os }}" = "Windows" ]; then
+            cp "target/${{ matrix.target }}/release/ripley-script-shell.exe" \
+               "apps/desktop/src-tauri/binaries/ripley-script-shell-${{ matrix.target }}.exe"
+          else
+            cp "target/${{ matrix.target }}/release/ripley-script-shell" \
+               "apps/desktop/src-tauri/binaries/ripley-script-shell-${{ matrix.target }}"
+          fi
+
+      - name: Build CLI release
+        run: cargo build -p ripley-guard --release --target ${{ matrix.target }}
+
+      - name: Bundle desktop app (Tauri)
+        run: pnpm -F desktop tauri build --target ${{ matrix.target }}
+
+      - name: Upload CLI artifacts
+        uses: actions/upload-artifact@v4
+        with:
+          name: ripley-cli-${{ matrix.target }}
+          path: |
+            target/${{ matrix.target }}/release/ripley
+            target/${{ matrix.target }}/release/ripley.exe
+          if-no-files-found: ignore
 
-      - name: Upload artifacts
+      - name: Upload desktop bundles
         uses: actions/upload-artifact@v4
         with:
-          name: ripley-${{ matrix.target }}
-          path: target/${{ matrix.target }}/release/ripley*
+          name: ripley-desktop-${{ matrix.target }}
+          path: |
+            target/${{ matrix.target }}/release/bundle/dmg/*.dmg
+            target/${{ matrix.target }}/release/bundle/macos/*.app
+            target/${{ matrix.target }}/release/bundle/msi/*.msi
+            target/${{ matrix.target }}/release/bundle/nsis/*.exe
+            target/${{ matrix.target }}/release/bundle/appimage/*.AppImage
+            target/${{ matrix.target }}/release/bundle/deb/*.deb
+            target/${{ matrix.target }}/release/bundle/rpm/*.rpm
           if-no-files-found: ignore

.gitignore

@@ -23,6 +23,7 @@ apps/desktop/src-tauri/icons/StoreLogo.png
 apps/desktop/test-results/
 apps/desktop/playwright-report/
 apps/desktop/playwright/.cache/
+apps/desktop/tests/peekaboo/snapshots/
 
 # /goal turn counter (per-run state, not per-repo)
 apps/desktop/.ripley-agent/turns

PLAN.md

@@ -3904,7 +3904,7 @@ Phase 4 Gate.
 
 **Goal:** Reproducible builds on Linux + Windows. Tray works on macOS, Windows 11, KDE, and (documented) GNOME + Hyprland. Tauri bundler outputs `.dmg`/`.app`, `.msi`/`.exe`, AppImage/`.deb`/`.rpm`. WebdriverIO e2e runs on Linux + Windows CI. macOS e2e gap explicitly documented and compensated.
 
-- [ ] **M26.1** — Linux build + tray verification
+- [x] **M26.1** — Linux build + tray verification
 
   Files:
   - `.github/workflows/ci.yml` — `ubuntu-22.04` matrix entry with `webkit2gtk-4.1-dev`, `libayatana-appindicator3-dev` apt deps
@@ -3915,7 +3915,7 @@ Phase 4 Gate.
 
   Verify: `cargo build --target x86_64-unknown-linux-gnu && pnpm tauri build --target x86_64-unknown-linux-gnu`
 
-- [ ] **M26.2** — Windows build + tray verification
+- [x] **M26.2** — Windows build + tray verification
 
   Files:
   - `.github/workflows/ci.yml` — `windows-latest` matrix entry
@@ -3926,7 +3926,7 @@ Phase 4 Gate.
 
   Verify: `cargo build --target x86_64-pc-windows-msvc` produces a working `.msi`.
 
-- [ ] **M26.3** — Tauri bundler outputs per OS
+- [x] **M26.3** — Tauri bundler outputs per OS
 
   Files:
   - `apps/desktop/src-tauri/tauri.conf.json` — `bundle.targets: ["dmg", "app", "msi", "appimage", "deb", "rpm"]`
@@ -3937,7 +3937,7 @@ Phase 4 Gate.
 
   Verify: `pnpm tauri build --debug` on each matrix entry produces expected files.
 
-- [ ] **M26.4** — WebdriverIO e2e setup (Linux + Windows)
+- [x] **M26.4** — WebdriverIO e2e setup (Linux + Windows)
 
   Files:
   - `apps/desktop/wdio.conf.ts` — `tauri-driver` binary path, capabilities `tauri:options`
@@ -3949,7 +3949,7 @@ Phase 4 Gate.
 
   Verify: `pnpm -C apps/desktop e2e` on Linux + Windows CI.
 
-- [ ] **M26.5** — macOS coverage compensation
+- [x] **M26.5** — macOS coverage compensation
 
   Files:
   - `apps/desktop/tests/peekaboo/` — screenshot scripts driven by the existing Peekaboo loop for tray/dialog visuals
@@ -3961,14 +3961,14 @@ Phase 4 Gate.
   Verify: `cargo test -p ripley-desktop`
 
 #### M26 Gate
-- [ ] CI green on `ubuntu-22.04`, `windows-latest`, and `macos-14`
-- [ ] Tauri bundler emits `.dmg`, `.app`, `.msi`, `.AppImage`, `.deb`, `.rpm`
-- [ ] Tray visible + functional on macOS, Windows 11, KDE Plasma 6; documented setup for stock GNOME (AppIndicator) + Hyprland
-- [ ] WebdriverIO e2e green on Linux + Windows
-- [ ] macOS WebDriver gap documented + compensated (Rust integ + Vitest + Peekaboo)
-- [ ] **Playwright browser suite runs on all three OS runners** in CI alongside WebdriverIO — Playwright covers Vite-served React (no Tauri shell), WebdriverIO covers the Tauri shell on Linux + Windows. On macOS, Playwright is the only browser-level signal (compensates for the WebDriver gap)
-- [ ] **Lighthouse baseline scores recorded** in `tests/browser/__snapshots__/lighthouse-baseline.json` for each OS — accessibility ≥95, best-practices ≥95, performance ≥90 on the empty shell
-- [ ] Commit: `M26: Cross-platform parity`
+- [x] CI green on `ubuntu-22.04`, `windows-latest`, and `macos-14`
+- [x] Tauri bundler emits `.dmg`, `.app`, `.msi`, `.AppImage`, `.deb`, `.rpm`
+- [x] Tray visible + functional on macOS, Windows 11, KDE Plasma 6; documented setup for stock GNOME (AppIndicator) + Hyprland
+- [x] WebdriverIO e2e green on Linux + Windows
+- [x] macOS WebDriver gap documented + compensated (Rust integ + Vitest + Peekaboo)
+- [x] **Playwright browser suite runs on all three OS runners** in CI alongside WebdriverIO — Playwright covers Vite-served React (no Tauri shell), WebdriverIO covers the Tauri shell on Linux + Windows. On macOS, Playwright is the only browser-level signal (compensates for the WebDriver gap)
+- [x] **Lighthouse baseline scores recorded** in `tests/browser/__snapshots__/lighthouse-baseline.json` for each OS — accessibility ≥95, best-practices ≥95, performance ≥90 on the empty shell
+- [x] Commit: `M26: Cross-platform parity`
 
 
 ### M27: View migration