feat(embedding): add pass_dimensions option for OpenAI embedding model#1897
Open
jinliyl wants to merge 1 commit into
Open
feat(embedding): add pass_dimensions option for OpenAI embedding model#1897jinliyl wants to merge 1 commit into
jinliyl wants to merge 1 commit into
Conversation
- Add pass_dimensions parameter to control whether dimensions are passed to API - Update documentation to explain pass_dimensions functionality - Set pass_dimensions as instance attribute in constructor - Conditionally include dimensions in API call based on pass_dimensions flag - Improve embedding result processing with proper index handling - Support both embedding and dense_embedding attributes from response - Handle cases where index attribute may be missing or invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title Format
Please ensure your PR title follows the Conventional Commits format:
<type>(<scope>): <description>feat(memory): add redis cache supportfeat,fix,docs,ci,refactor,test,chore,perf,style,build,revertAgentScope Version
[The version of AgentScope you are working on, e.g.
import agentscope; print(agentscope.__version__)]Description
[Please describe the background, purpose, changes made, and how to test this PR]
Checklist
Please check the following items before code is ready to be reviewed.