fix(agent): emit ThinkingBlockEnd before TextBlockStart at reasoning→answer boundary#1887
Open
qbc2016 wants to merge 1 commit into
Open
fix(agent): emit ThinkingBlockEnd before TextBlockStart at reasoning→answer boundary#1887qbc2016 wants to merge 1 commit into
qbc2016 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope Version
2.0.2
Description
In
_convert_chat_response_to_event, text blocks were processed before thinking blocks, causingThinkingBlockEndEventto be emitted afterTextBlockDeltaEventat the reasoning→answer boundary. This trapped thefirst answer token(s) inside the
<think>block for any downstream renderer.Fix the ordering by splitting the logic into three explicit steps per chunk:
This ensures
ThinkingBlockEnd → TextBlockStart → TextBlockDeltaat the boundary, and also fixes the edge case where a single chunk carries both aThinkingBlockand aTextBlock.Fixes #1885.
Checklist
Please check the following items before code is ready to be reviewed.