Skip to content

fix(embedding): omit default OpenAI dimensions#1874

Open
Premsenareddy wants to merge 1 commit into
agentscope-ai:mainfrom
Premsenareddy:codex/openai-embedding-optional-dimensions
Open

fix(embedding): omit default OpenAI dimensions#1874
Premsenareddy wants to merge 1 commit into
agentscope-ai:mainfrom
Premsenareddy:codex/openai-embedding-optional-dimensions

Conversation

@Premsenareddy

Copy link
Copy Markdown
Contributor

Summary

  • make OpenAI embedding dimensions optional at runtime so OpenAI-compatible providers can use their native defaults
  • only send the dimensions parameter when explicitly configured
  • keep YAML model-card defaults rendering as concrete integer schemas for built-in OpenAI models

Fixes #1831

Tests

  • .venv/bin/python -m pytest tests/embedding_openai_test.py -q
  • .venv/bin/python -m pytest tests/embedding_openai_test.py tests/embedding_dashscope_test.py tests/embedding_gemini_test.py tests/embedding_ollama_test.py -q -p no:cacheprovider
  • .venv/bin/pre-commit run --files src/agentscope/embedding/_embedding_base.py src/agentscope/embedding/_embedding_model_card.py src/agentscope/embedding/_openai/_model.py tests/embedding_openai_test.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Model "Qwen3-Embedding-0.6B" does not support matryoshka representation,

1 participant