agents: allow composition refs on BYO image Agents - #624
Open
xytian315 wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the v1alpha1 Agent API validation rules to allow composition references (plugins, skills, instructions) on “bring-your-own image” Agents when spec.source.image is non-blank, aligning with the stated goal of lifting the previous compatibleHarnesses gate for image-based Agents.
Changes:
- Relaxed AgentSpec validation so plugins/skills/instructions are allowed when either
compatibleHarnessesis set or a non-blankspec.source.imageis provided. - Updated API comments/documentation to reflect the new composition delivery rules for image Agents.
- Expanded unit tests to cover the new acceptance/rejection matrix (image vs harness vs repository source).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/api/v1alpha1/agent.go | Updates AgentSpec composition docs to reflect that image Agents can receive composed plugins/skills/instructions. |
| pkg/api/v1alpha1/agent_validate.go | Adjusts validation gate to permit composition refs when spec.source.image is non-blank. |
| pkg/api/v1alpha1/agent_harness_validate_test.go | Adds coverage for image Agents using plugins/skills/instructions and keeps rejection cases for missing image+harness. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
xytian315
marked this pull request as draft
August 18, 2026 06:21
xytian315
marked this pull request as ready for review
August 20, 2026 05:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation:
This lifts the gate for BYO image Agents: plugins, skills, and instructions are accepted when the Agent has a non-blank source image.
Change Type
/kind feature
Changelog
Additional Notes