correct to use actual xoshiro128++ implementation#1210
Open
corwinkuiper wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During transcription there appears to be an error that was introduced such that we ended up using some strange combination of xoshiro128++ and xoshiro128**. This corrects it to use xoshiro128++.
Here is the original C implementation:
The only error I spotted being that we multiplied by 9 rather than adding
s[0]on the first line.This requires a
0.Xbump as we said we wouldn't change this in minor releases (we're still V0, so the third number is considered the minor release).