Fix AttributeError in domains.list() for accounts with no domains#11
Open
SAY-5 wants to merge 1 commit into
Open
Fix AttributeError in domains.list() for accounts with no domains#11SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10.
domains.list()crashes on any account with zero domains because Namecheap returns a self-closing<DomainGetListResult />, which xmltodict parses asNone. The path walk inbase.pythen called.get()on thatNone. Guarding each segment with(result or {})lets it fall through to the existing empty-result branch and return[].I pulled the walk into a small
navigate_pathhelper and added abase_check.pyboundary check alongside it, covering the empty-account case plus the normal and missing-key paths.