Skip to content

MWPW-192812 only considering same locale variations for pzn#772

Merged
3ch023 merged 7 commits intomainfrom
MWPW-192812
Apr 24, 2026
Merged

MWPW-192812 only considering same locale variations for pzn#772
3ch023 merged 7 commits intomainfrom
MWPW-192812

Conversation

@npeltier
Copy link
Copy Markdown
Contributor

@npeltier npeltier commented Apr 16, 2026

Resolves https://jira.corp.adobe.com/browse/MWPW-192812
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

Test URLs:

Plans Page URLs:

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 16, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.32%. Comparing base (a25ffda) to head (fc317a8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
- Coverage   87.36%   87.32%   -0.04%     
==========================================
  Files         210      210              
  Lines       62870    62872       +2     
==========================================
- Hits        54924    54906      -18     
- Misses       7946     7966      +20     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438e155...fc317a8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@3ch023 3ch023 requested a review from yesil April 16, 2026 15:52
@afmicka afmicka added the RCP-restricted Pull request should not be merged during RCP label Apr 20, 2026
@afmicka
Copy link
Copy Markdown
Contributor

afmicka commented Apr 20, 2026

@afmicka
Copy link
Copy Markdown
Contributor

afmicka commented Apr 21, 2026

@npeltier There is this US page, when visited from akamaiLocale=GR should show the grouped variation that is created the US for the gr_en locale. However, it is showing US default (id: 3b262889-7ab2-4555-8e9d-147f92fc7c4c) and not grouped variation (id: d0227f29-2768-4742-91e4-eff4a500e52b)
https://main--cc--adobecom.aem.page/cc-shared/fragments/drafts/mariia/go-live-checks/plans-row-geo-enabled/plans?akamaiLocale=GR&maslibs=mwpw-192812--mas--adobecom

check prod: https://main--cc--adobecom.aem.page/cc-shared/fragments/drafts/mariia/go-live-checks/plans-row-geo-enabled/plans?akamaiLocale=GR

also it is breaking the bug reported in https://jira.corp.adobe.com/browse/MWPW-192444. Both card in collection and standalone are showing US default instead of grouped gr_en variation

@afmicka afmicka removed the RCP-restricted Pull request should not be merged during RCP label Apr 23, 2026
@3ch023 3ch023 merged commit 52ce407 into main Apr 24, 2026
15 of 16 checks passed
@3ch023 3ch023 deleted the MWPW-192812 branch April 24, 2026 10:15
Axelcureno pushed a commit that referenced this pull request Apr 24, 2026
* MWPW-192812 only considering same locale variations for pzn

* MWPW-192812 fixing pattern for pzn

---------

Co-authored-by: Honwai Wong <hwong@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants