MWPW-193327 - [infra] make nala test GH runners more stable and robust#771
Merged
MWPW-193327 - [infra] make nala test GH runners more stable and robust#771
Conversation
Intermittent nala test failures on self-hosted runners were caused by two apt failure modes: unattended-upgrades holding dpkg/apt locks, and transient Ubuntu mirror sync errors during apt-get update. Add a composite action (.github/actions/prep-apt) that stops background apt services, waits up to 120s for all locks to clear, then runs npx playwright install-deps with up to 3 retries (15s apart). Apply the composite action to all three self-hosted workflows (run-nala.yml studio job, run-nala-daily.yml, run-nala-milolibs.yaml), replacing the previous unconditional bare install-deps call. Also adds continue-on-error: true to the Playwright cache steps in daily and milolibs, consistent with the studio job. The GitHub-hosted docs job in run-nala.yml is unchanged — it does not share the self-hosted runner apt environment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
==========================================
- Coverage 87.46% 87.44% -0.02%
==========================================
Files 210 210
Lines 63081 63081
==========================================
- Hits 55172 55164 -8
- Misses 7909 7917 +8 see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
npeltier
previously requested changes
Apr 20, 2026
Contributor
npeltier
left a comment
There was a problem hiding this comment.
would you mind creating a JIRA and attaching that PR to it?
Contributor
Author
Done, ticket created: https://jira.corp.adobe.com/browse/MWPW-193327 |
mirafedas
approved these changes
Apr 24, 2026
Ticket has been created, dismissing review due to absence.
afmicka
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intermittent nala test failures on self-hosted runners were caused by two apt failure modes: unattended-upgrades holding dpkg/apt locks, and transient Ubuntu mirror sync errors during apt-get update.
Add a composite action (.github/actions/prep-apt) that stops background apt services, waits up to 120s for all locks to clear, then runs npx playwright install-deps with up to 3 retries (15s apart).
Apply the composite action to all three self-hosted workflows (run-nala.yml studio job, run-nala-daily.yml, run-nala-milolibs.yaml), replacing the previous unconditional bare install-deps call. Also adds continue-on-error: true to the Playwright cache steps in daily and milolibs, consistent with the studio job.
The GitHub-hosted docs job in run-nala.yml is unchanged — it does not share the self-hosted runner apt environment.
Resolves https://jira.corp.adobe.com/browse/MWPW-193327
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: