Skip to content

MWPW-190447 Activate Alpha sorting of M@S cols in Tabular view#718

Closed
Blainegunn wants to merge 2 commits intomainfrom
MWPW-190447
Closed

MWPW-190447 Activate Alpha sorting of M@S cols in Tabular view#718
Blainegunn wants to merge 2 commits intomainfrom
MWPW-190447

Conversation

@Blainegunn
Copy link
Copy Markdown
Contributor

Activate Alpha sorting of M@S cols in Tabular view

  • Add sort support for Path, Fragment Title, and Last Modified columns
  • Remove sortable attribute from non-sortable columns (Offer ID, Offer Type, Last Modified By, Price, Status)
  • Add sort StoreController and sortedFragments getter to MasContent
  • Register content sort columns in SORT_COLUMNS constant

Resolves https://jira.corp.adobe.com/browse/MWPW-190447
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

…t modified)

- Add sort support for Path, Fragment Title, and Last Modified columns
- Remove sortable attribute from non-sortable columns (Offer ID, Offer Type, Last Modified By, Price, Status)
- Add sort StoreController and sortedFragments getter to MasContent
- Register content sort columns in SORT_COLUMNS constant

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Mar 26, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 10.16949% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.42%. Comparing base (bc24e38) to head (3ac4c2e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
studio/src/mas-content.js 10.16% 53 Missing ⚠️

❌ Your patch check has failed because the patch coverage (10.16%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   86.29%   86.42%   +0.13%     
==========================================
  Files         199      199              
  Lines       58827    58878      +51     
==========================================
+ Hits        50763    50886     +123     
+ Misses       8064     7992      -72     
Files with missing lines Coverage Δ
studio/src/mas-content.js 46.75% <10.16%> (-10.82%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc24e38...3ac4c2e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant