MWPW-190447 Activate Alpha sorting of M@S cols in Tabular view#718
Closed
Blainegunn wants to merge 2 commits intomainfrom
Closed
MWPW-190447 Activate Alpha sorting of M@S cols in Tabular view#718Blainegunn wants to merge 2 commits intomainfrom
Blainegunn wants to merge 2 commits intomainfrom
Conversation
…t modified) - Add sort support for Path, Fragment Title, and Last Modified columns - Remove sortable attribute from non-sortable columns (Offer ID, Offer Type, Last Modified By, Price, Status) - Add sort StoreController and sortedFragments getter to MasContent - Register content sort columns in SORT_COLUMNS constant Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (10.16%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
+ Coverage 86.29% 86.42% +0.13%
==========================================
Files 199 199
Lines 58827 58878 +51
==========================================
+ Hits 50763 50886 +123
+ Misses 8064 7992 -72
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activate Alpha sorting of M@S cols in Tabular view
Resolves https://jira.corp.adobe.com/browse/MWPW-190447
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: