Skip to content

MWPW-190754: compare-chart WIP#713

Closed
yesil wants to merge 8 commits intomainfrom
MWPW-190754
Closed

MWPW-190754: compare-chart WIP#713
yesil wants to merge 8 commits intomainfrom
MWPW-190754

Conversation

@yesil
Copy link
Copy Markdown
Contributor

@yesil yesil commented Mar 25, 2026

Resolves https://jira.corp.adobe.com/browse/MWPW-190754
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Mar 25, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@yesil
Copy link
Copy Markdown
Contributor Author

yesil commented Apr 28, 2026

closing for now, this feature must be implemented with #770 and #769 after finalizing the discussions.

@yesil yesil closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants