MWPW-192736: Add check for milolibs query param#373
Open
zagi25 wants to merge 1 commit intoadobecom:stagefrom
Open
MWPW-192736: Add check for milolibs query param#373zagi25 wants to merge 1 commit intoadobecom:stagefrom
zagi25 wants to merge 1 commit intoadobecom:stagefrom
Conversation
The milolibs query param was interpolated directly into a template literal used for a dynamic import(), letting an attacker point module loading at an arbitrary origin and execute JS in the page context. Add a strict whitelist (^[a-zA-Z0-9_-]+$) and throw on invalid input in express/code/scripts/utils.js. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stage #373 +/- ##
========================================
Coverage ? 64.86%
========================================
Files ? 312
Lines ? 70811
Branches ? 0
========================================
Hits ? 45929
Misses ? 24882
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zagi25
changed the title
fullcolorcoder
approved these changes
Apr 17, 2026
nateyolles
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whitelist branch parameter with
/^[a-zA-Z0-9_-]+$/; throw on any other characters.Ticket
https://jira.corp.adobe.com/browse/MWPW-192736
Test URLs
Before: https://stage--da-express-milo--adobecom.aem.page/
After: https://MWPW-192736--da-express-milo--zagi25.aem.page/
This PR was generated by Claude (Anthropic's Claude Code CLI).