Google yolo#343
Draft
echen-adobe wants to merge 8 commits intostagefrom
Draft
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Express-owned Google One Tap (YOLO) auto sign-in so it can be driven from the Express codebase instead of only Milo. Initialization runs from
express-delayed.jsafter IMS is available: it loads the Google GSI client, mounts the prompt under the federated profile placeholder, and signs the user in viaadobeIMS.socialHeadlessSignIn(with fallback tosignInWithSocialProviderfor new accounts).Author controls (page metadata):
google-login:on|desktop|mobileto enable One Tap and restrict by viewport (anything else leaves it off).google-yolo-zero-tap: set toonforauto_select(silent / second-visit style behavior when Google allows it).google-login-redirect: optional absolute URL to send users after a successful existing-account sign-in; otherwise the page reloads (or SUSI redirect flow for new accounts).google-login-accepted-tou-list: optional; passed through asaccepted_tou_listfor progressive / TOU behavior (aligned with Identity expectations).Milo coordination: a default
google-loginmeta is appended afterloadArea()inscripts.jsso Milo’s delayed path does not treat the page as YOLO-enabled before Express takes ownership—reducing duplicate One Tap behavior (authors can still override via document metadata).Jira Ticket
Resolves: MWPW-188779
Test URLs
Draft demo (metadata / flow): https://google-yolo--da-express-milo--adobecom.aem.page/drafts/echen/blog-yolo
Verification Steps
google-login=on/desktop/mobileas appropriate for your viewport).google-login-redirectwhen set, or reload when not; new user flow should continue via social sign-in as implemented.google-loginenabled (or with an unsupported value), confirm One Tap from this Express path does not run (only Milo may still run on some pages until fully decoupled).main, Express does not own this flow; on this branch, Express initializes One Tap from delayed scripts with the metadata behavior above. Expect possible brief double prompt while both Milo and Express One Tap exist—widget may flash as each stack runs (as noted on the ticket).Potential Regressions
google-loginmeta (desktop) afterloadArea.google-login-accepted-tou-listcould affect progressive-account / TOU expectations—validate with Identity for production metadata.desktopvsmobilemust be verified on real breakpoints (code usesmin-width: 900px).Additional Notes
accepted_tou_listdiscussion: milo#5401.