CN Redirect Update 2#294
Merged
express-milo-merge-bot[bot] merged 22 commits intostagefrom Apr 22, 2026
Merged
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
fullcolorcoder
approved these changes
Apr 7, 2026
Contributor
fullcolorcoder
left a comment
fullcolorcoder
left a comment
There was a problem hiding this comment.
Looks good, added a suggested commit for a lana log on fail.
| const isAdobeOrigin = /^(www\.stage\.|www\.)adobe\.com$/.test(window.location.hostname); | ||
| import('./utils/location-utils.js').then(({ getCountry }) => getCountry()).then((country) => { | ||
| if (country === 'cn') { window.location.href = '/cn'; } | ||
| if (country === 'cn' && isAdobeOrigin && !window.location.pathname.startsWith('/cn') && !window.isErrorPage) { window.location.href = '/cn'; } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (country === 'cn' && isAdobeOrigin && !window.location.pathname.startsWith('/cn') && !window.isErrorPage) { window.location.href = '/cn'; } | |
| if (country === 'cn' && isAdobeOrigin && !window.location.pathname.startsWith('/cn') && !window.isErrorPage) { window.location.href = '/cn'; } | |
| }).catch((err) => { | |
| window.lana?.log(`CN redirect failed: ${err}`, { tags: 'scripts', severity: 'error' }); | |
| }); |
maxn-adobe
approved these changes
Apr 8, 2026
Contributor
|
Skipped merging 294: CN Redirect Update 2 due to failing or running checks |
2 similar comments
Contributor
|
Skipped merging 294: CN Redirect Update 2 due to failing or running checks |
Contributor
|
Skipped merging 294: CN Redirect Update 2 due to failing or running checks |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Briefly describe the features or fixes introduced in this PR.
Gracefully redirect user to 404 page if the country param is
cnand the content does not exist.Jira Ticket
Resolves: https://jira.corp.adobe.com/browse/MWPW-191183
Test URLs
Verification Steps