feat: add medialog endpoint to helix6#205
Merged
amol-anand merged 4 commits intomainfrom Apr 23, 2026
Merged
Conversation
|
This PR will trigger a minor release when merged. |
Comment on lines
+34
to
+36
| if (!contentBusId) { | ||
| return errorResponse(log, 400, 'Unable to resolve contentBusId for this site'); | ||
| } |
Contributor
There was a problem hiding this comment.
not necessary: org and site will have been resolved upon calling this handler, so there is a content bus id
Contributor
Author
There was a problem hiding this comment.
Good catch — removed in 7a7e879. You're right, the middleware guarantees contentBusId is resolved by the time we reach the handler.
Comment on lines
+26
to
+29
| if (!contentBusId) { | ||
| log.warn('Unable to send media log entry: contentBusId is empty'); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
again: not possible AFAIU
Contributor
|
Tests are very nicely structured and easily understandable 🥇 |
amol-anand
added a commit
that referenced
this pull request
Apr 18, 2026
Addresses review feedback on PR #205: org/site are resolved by middleware before the handler runs, so contentBusId is guaranteed to be present. The guards were dead code. Made-with: Cursor
dominique-pfister
approved these changes
Apr 19, 2026
tripodsan
approved these changes
Apr 20, 2026
Addresses review feedback on PR #205: org/site are resolved by middleware before the handler runs, so contentBusId is guaranteed to be present. The guards were dead code. Made-with: Cursor
- Drop unreachable `!contentBusId` guard in query.js (same reason as the add.js/support cleanup in 021b584: org/site are resolved by middleware before the handler runs). - Remove the unused standalone `mediaLog` helper from support/medialog.js; only `MediaLogBatch` is consumed (by add.js). Made-with: Cursor
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 23, 2026
# [1.51.0](v1.50.0...v1.51.0) (2026-04-23) ### Features * add medialog endpoint to helix6 ([#205](#205)) ([41e2eea](41e2eea))
|
🎉 This PR is included in version 1.51.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#177