fix(networks): move Tatara entry from PRODUCTION_NETWORKS to TEST_NETWORKS#7
Open
Nexory wants to merge 1 commit into
Open
fix(networks): move Tatara entry from PRODUCTION_NETWORKS to TEST_NETWORKS#7Nexory wants to merge 1 commit into
Nexory wants to merge 1 commit into
Conversation
…WORKS TATARA (chain ID 129399) is declared as a testnet in TESTNET_SEPOLIA_CHAIN_IDs (line 9) but its PublicNetwork entry was placed inside PRODUCTION_NETWORKS, creating a classification inconsistency. Code consulting MAINNET-vs-TESTNET maps to route or filter would see TATARA classified differently depending on which map is read. This commit moves the Tatara entry from PRODUCTION_NETWORKS to TEST_NETWORKS preserving the existing field values. The empty publicRPC and blockExplorer fields are preserved as-is with a TODO comment — populating them with authoritative Katana testnet endpoints is left for a follow-up by someone with access to the official Katana team's endpoint list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TATARA (chain ID 129399) is declared as a testnet at
src/networks.ts:9:```ts
export const TESTNET_SEPOLIA_CHAIN_IDs = {
...
TATARA: 129399,
...
};
```
But its
PublicNetworkentry was placed insidePRODUCTION_NETWORKS(old line 233), creating a classification mismatch. Code that consultsMAINNET_CHAIN_IDsversusTESTNET_*_CHAIN_IDsto filter or route would see TATARA classified as testnet, while code that iteratesPRODUCTION_NETWORKSwould treat it as mainnet.What changed
Moved the Tatara entry from
PRODUCTION_NETWORKStoTEST_NETWORKS, preserving the existing field values exactly. Added a// TODO:comment for the emptypublicRPC/blockExplorerfields so the next maintainer touching this code is aware that the official Katana team's testnet endpoint list still needs to be populated there.```diff
```
Impact
PUBLIC_NETWORKS(which spreads both maps atL608) still includes TATARA — no breaking change for downstream consumersPRODUCTION_NETWORKSno longer misrepresents TATARA as mainnetTEST_NETWORKScorrectly contains the entry, aligned with the chain ID declaration atL9What I did NOT change
publicRPCandblockExplorervalues are preserved as-is. Populating them with authoritative Katana testnet endpoints is left for someone with access to the official Katana team's endpoint list — happy to do that in a follow-up if pointed at the right source.Notes
This issue was found during an audit of the across-protocol SDK ecosystem.