Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@across-protocol/constants",
"version": "3.1.109",
"version": "3.1.110",
"description": "Export commonly re-used values for Across repositories",
"repository": {
"type": "git",
Expand Down
20 changes: 20 additions & 0 deletions src/networks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,16 @@ export const PRODUCTION_NETWORKS: { [chainId: number]: PublicNetwork } = {
oftEid: PRODUCTION_OFT_EIDs.BSC,
hypDomainId: MAINNET_CHAIN_IDs.BSC,
},
[CHAIN_IDs.BOB]: {
name: "BOB",
family: OP_STACK,
nativeToken: "ETH",
publicRPC: "https://rpc.gobob.xyz",
blockExplorer: "https://explorer.gobob.xyz",
cctpDomain: CCTP_NO_DOMAIN,
oftEid: OFT_NO_EID,
hypDomainId: HYPERLANE_NO_DOMAIN_ID,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Set BOB Hyperlane domain to its actual domain ID

This entry marks BOB as having no Hyperlane domain (-1), but Hyperlane’s published domain list includes BOB with domain 60808 (matching its chain ID). Any downstream code that gates Hyperlane features on hypDomainId !== -1 will incorrectly disable BOB routing/messaging even though the chain is supported, so BOB-specific Hyperlane flows introduced by this network addition will never activate.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

},
[CHAIN_IDs.BOBA]: {
name: "Boba",
family: OP_STACK,
Expand Down Expand Up @@ -506,6 +516,16 @@ export const TEST_NETWORKS: { [chainId: number]: PublicNetwork } = {
oftEid: TESTNET_OFT_EIDs.HYPEREVM_TESTNET,
hypDomainId: TESTNET_CHAIN_IDs.HYPEREVM_TESTNET,
},
[CHAIN_IDs.INK_SEPOLIA]: {
name: "Ink Sepolia",
family: OP_STACK,
nativeToken: "ETH",
publicRPC: "https://rpc-gel-sepolia.inkonchain.com",
blockExplorer: "https://explorer-sepolia.inkonchain.com",
cctpDomain: 21,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove unsupported CCTP domain for Ink Sepolia

cctpDomain: 21 marks Ink Sepolia as CCTP-enabled, but TOKEN_SYMBOLS_MAP.USDC.addresses has no CHAIN_IDs.INK_SEPOLIA entry in src/tokens.ts (USDC section), unlike every other non-CCTP_NO_DOMAIN network. In consumers that treat cctpDomain != -1 as “USDC via CCTP is available,” this can produce undefined token-address lookups and failed routing/bridging flows for Ink Sepolia. Either add the Ink Sepolia USDC address or set this field to CCTP_NO_DOMAIN until USDC support is present.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

oftEid: OFT_NO_EID,
hypDomainId: HYPERLANE_NO_DOMAIN_ID,
},
[CHAIN_IDs.LENS_SEPOLIA]: {
name: "Lens Sepolia",
family: ZK_STACK,
Expand Down
1 change: 1 addition & 0 deletions src/tokens.ts
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,7 @@ export const TOKEN_SYMBOLS_MAP = {
[CHAIN_IDs.HYPEREVM]: "0xb88339CB7199b77E23DB6E890353E22632Ba630f",
[CHAIN_IDs.HYPEREVM_TESTNET]: "0x2B3370eE501B4a559b57D449569354196457D8Ab",
[CHAIN_IDs.INK]: "0x2D270e6886d130D724215A266106e6832161EAEd",
[CHAIN_IDs.INK_SEPOLIA]: "0xFabab97dCE620294D2B0b0e46C68964e326300Ac",
[CHAIN_IDs.LINEA]: "0x176211869cA2b568f2A7D4EE941E073a821EE1ff",
[CHAIN_IDs.LENS]: "0x88F08E304EC4f90D644Cec3Fb69b8aD414acf884",
[CHAIN_IDs.MAINNET]: "0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48",
Expand Down