-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Missing Bob & Ink Sepolia #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -183,6 +183,16 @@ export const PRODUCTION_NETWORKS: { [chainId: number]: PublicNetwork } = { | |
| oftEid: PRODUCTION_OFT_EIDs.BSC, | ||
| hypDomainId: MAINNET_CHAIN_IDs.BSC, | ||
| }, | ||
| [CHAIN_IDs.BOB]: { | ||
| name: "BOB", | ||
| family: OP_STACK, | ||
| nativeToken: "ETH", | ||
| publicRPC: "https://rpc.gobob.xyz", | ||
| blockExplorer: "https://explorer.gobob.xyz", | ||
| cctpDomain: CCTP_NO_DOMAIN, | ||
| oftEid: OFT_NO_EID, | ||
| hypDomainId: HYPERLANE_NO_DOMAIN_ID, | ||
| }, | ||
| [CHAIN_IDs.BOBA]: { | ||
| name: "Boba", | ||
| family: OP_STACK, | ||
|
|
@@ -506,6 +516,16 @@ export const TEST_NETWORKS: { [chainId: number]: PublicNetwork } = { | |
| oftEid: TESTNET_OFT_EIDs.HYPEREVM_TESTNET, | ||
| hypDomainId: TESTNET_CHAIN_IDs.HYPEREVM_TESTNET, | ||
| }, | ||
| [CHAIN_IDs.INK_SEPOLIA]: { | ||
| name: "Ink Sepolia", | ||
| family: OP_STACK, | ||
| nativeToken: "ETH", | ||
| publicRPC: "https://rpc-gel-sepolia.inkonchain.com", | ||
| blockExplorer: "https://explorer-sepolia.inkonchain.com", | ||
| cctpDomain: 21, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Useful? React with 👍 / 👎.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @codex review |
||
| oftEid: OFT_NO_EID, | ||
| hypDomainId: HYPERLANE_NO_DOMAIN_ID, | ||
| }, | ||
| [CHAIN_IDs.LENS_SEPOLIA]: { | ||
| name: "Lens Sepolia", | ||
| family: ZK_STACK, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entry marks BOB as having no Hyperlane domain (
-1), but Hyperlane’s published domain list includes BOB with domain60808(matching its chain ID). Any downstream code that gates Hyperlane features onhypDomainId !== -1will incorrectly disable BOB routing/messaging even though the chain is supported, so BOB-specific Hyperlane flows introduced by this network addition will never activate.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
979b69f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codex review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Didn't find any major issues. Hooray!
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".