test(playground): fix TipTap regression test build on mr-template-editor#886
Open
Rishabh060105 wants to merge 1 commit intoaccordproject:mr-template-editorfrom
Conversation
Signed-off-by: Rishabh Jain <rishabhj2005@email.com>
Author
|
Hi @mttrbrts I opened this follow-up to restore the Netlify/build checks on Changes in this PR:
What I found on the base branch:
So this PR is intended as a narrow build-fix follow-up on top of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes N/A
Restores the Netlify/build pipeline on
mr-template-editorafter the new TipTap regression test introduced a TypeScript build failure.This PR addresses a follow-up issue from PR #878 where
src/tests/components/TiptapTemplateEditor.test.tsxstored a plain object inmodelManager. That worked in the mocked Vitest path, but failedtscbecause the Zustand store expects a realModelManagerinstance. As a result,npm run buildfailed and the Netlify deploy checks could not complete successfully.Changes
src/tests/components/TiptapTemplateEditor.test.tsxto use a realModelManagerinstance instead of a plain{ id: string }object.TiptapTemplateEditor, store behavior, or any user-facing runtime flow.npm run buildnpx vitest run src/tests/components/TiptapTemplateEditor.test.tsxnpx vitest run src/tests/store/setData.test.tsxnpm run test:unitFlags
mr-template-editorbuild regression rather than broadening into runtime/editor changes from PR feat(templateMark): add rich text editor #878.vite.config.tsand the rebuild/model-loading path were reviewed, but no broader rollback was needed once the TypeScript test failure was fixed.Screenshots or Video
N/A - this is a build/test fix. The behavior is covered by build and unit test verification rather than a visual UI change.
Related Issues
Author Checklist
--signoffoption of git commit.mr-template-editorfromfork:branchname