Skip to content

fix(a11y): add keyboard activation to sidebar navigation items#849

Closed
colswap wants to merge 1 commit intoaccordproject:mainfrom
colswap:fix/sidebar-keyboard-a11y
Closed

fix(a11y): add keyboard activation to sidebar navigation items#849
colswap wants to merge 1 commit intoaccordproject:mainfrom
colswap:fix/sidebar-keyboard-a11y

Conversation

@colswap
Copy link
Copy Markdown

@colswap colswap commented Mar 23, 2026

Closes #842

Sidebar navigation items use role="button" with tabIndex={0}, making
them focusable for keyboard users, but no onKeyDown handler was present.
Pressing Enter or Space did nothing.

Changes

  • Added onKeyDown handler to navTop sidebar items
  • Added onKeyDown handler to navBottom sidebar items
  • Both handlers trigger onClick on Enter or Space, matching the existing pattern in ProblemPanel.tsx

Flags

  • None

Screenshots or Video

  • N/A (keyboard interaction, not visual change)

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Signed-off-by: colswap <colswap@gmail.com>
@colswap colswap requested a review from a team as a code owner March 23, 2026 08:47
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 23, 2026

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 90c1826
🔍 Latest deploy log https://app.netlify.com/projects/ap-template-playground/deploys/69c0fe3bcca8340008bbee53
😎 Deploy Preview https://deploy-preview-849--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the Stale label Apr 8, 2026
@github-actions github-actions Bot closed this Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug(a11y): Sidebar navigation items are not activatable via keyboard (Enter/Space)

1 participant