Fix deploy preview install failures caused by runtime mismatch and nested dependency scripts#834
Closed
divyansh-cyber wants to merge 2 commits intoaccordproject:mainfrom
Closed
Fix deploy preview install failures caused by runtime mismatch and nested dependency scripts#834divyansh-cyber wants to merge 2 commits intoaccordproject:mainfrom
divyansh-cyber wants to merge 2 commits intoaccordproject:mainfrom
Conversation
Signed-off-by: Divyansh Rai <140232173+divyansh-cyber@users.noreply.github.com>
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates runtime configuration to align deploy-preview installs with dependencies that expect a newer Node/npm toolchain, targeting Netlify and project engine metadata.
Changes:
- Bumped
package.jsonengines to require Node>=20and npm>=10. - Updated the top-level engine metadata in
package-lock.jsonto match. - Added
netlify.tomlto pin Netlify build environment to Node 20 / npm 10.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Raises declared Node/npm engine requirements to match current dependency expectations. |
| package-lock.json | Updates the root package engine metadata stored in the lockfile. |
| netlify.toml | Pins Netlify deploy-preview runtime (Node/npm) to avoid Node 18 install failures. |
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
6
to
9
| "engines": { | ||
| "node": ">=18", | ||
| "npm": ">=6" | ||
| "node": ">=20", | ||
| "npm": ">=10" | ||
| }, |
|
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses deploy-preview install failures seen after the Concerto v4 beta validation work.
Problem
Deploy logs showed:
Changes
Fixes : #833