fix(lint): resolve follow-up review findings from #825#826
fix(lint): resolve follow-up review findings from #825#826bnyashwanth wants to merge 6 commits intoaccordproject:mainfrom
Conversation
Signed-off-by: bnyashwanth <bnyashwanth2006@gmail.com>
I, bnyashwanth <bnyashwanth2006@gmail.com>, hereby add my Signed-off-by to this commit: 84fb586 Signed-off-by: bnyashwanth <bnyashwanth2006@gmail.com>
I, bnyashwanth <bnyashwanth2006@gmail.com>, hereby add my Signed-off-by to this commit Signed-off-by: bnyashwanth <bnyashwanth2006@gmail.com>
Signed-off-by: bnyashwanth <bnyashwanth2006@gmail.com>
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Follow-up cleanup PR for #825 (post-#725/#825 review findings), focused on tightening lint/test utilities and removing minor technical debt around error parsing and ESLint suppression placement.
Changes:
- Refines test environment mocks (matchMedia + canvas) and clarifies test mock intent/comments.
- Simplifies/cleans up
extractErrorMessageJSON parsing flow and removes dead/unused branching patterns. - Narrows
react-refresh/only-export-componentssuppression to the intended export.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/testing/setup.ts |
Refactors jsdom test mocks (matchMedia + HTMLCanvasElement.getContext) for clearer intent and better typing. |
src/utils/helpers/errorUtils.ts |
Cleans up error parsing utility with typed JSON parsing structures and removed dead logic. |
src/tests/components/SettingsModal.test.tsx |
Aligns Zustand store mock signature/types and updates comments for clarity. |
src/contexts/MarkdownEditorContext.tsx |
Moves ESLint disable-next-line to scope it to the specific export. |
.gitignore |
Adds a root gitignore file (note: contains unexpected trailing control characters). |
|
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Thanks for this contribution! Before we can review, please resolve the merge conflicts with the base branch. git fetch origin main
git rebase origin/main
# Resolve conflicts
git push --force-with-leaseOnce the conflicts are resolved, we'll proceed with the review. This comment was generated by AI on behalf of @mttrbrts. |
Summary
Resolves follow-up cleanup items from #825 after #725.
Changes made
Removed dead empty branch in error parsing utility.
Replaced process-style mock comment with intent-focused comment in tests.
Ensured eslint disable-next-line is correctly scoped to the intended export.
Validation
npm run test
npm run lint (current repository has unrelated pre-existing lint failures in AIConfigPopup; no new errors introduced by these changes)
Closes #825