-
-
Notifications
You must be signed in to change notification settings - Fork 222
fix(ui): add visual error toast notification for corrupted share links #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tirth707
wants to merge
8
commits into
accordproject:main
Choose a base branch
from
tirth707:fix-share-link-error-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−44
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
62bc55b
fix(ui): add visual error toast notification for corrupted share links
tirth707 41c6139
fix(ui): broaden error matcher, add init fallback, and add e2e test f…
tirth707 b4eb227
fix(test): correct preview selector and add void to antd message promise
tirth707 02047a2
test: increase spinner timeout to 30s to prevent CI flakiness
tirth707 5cc4e68
Merge main into fix-share-link-error-ui to resolve import conflicts
tirth707 2a1e26c
Merge branch 'main' into fix-share-link-error-ui
tirth707 94dad58
Merge branch 'main' into fix-share-link-error-ui
tirth707 3de5945
Potential fix for pull request finding
tirth707 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.