Fix path traversal in absltest.create_file#405
Open
rootvector2 wants to merge 1 commit intoabseil:mainfrom
Open
Fix path traversal in absltest.create_file#405rootvector2 wants to merge 1 commit intoabseil:mainfrom
rootvector2 wants to merge 1 commit intoabseil:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures create_file only writes inside the temp directory.
It normalizes the input path, rejects absolute paths, and checks that the final path stays within the base directory.
Valid relative paths continue to work as before. Added tests for both valid and invalid cases.