Added IOwnable interface to support integrations#1312
Open
web3devLuBdF wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1283
An IOwnable.sol file has been added as an interface for the owner function, to facilitate integration with those who need to verify the owner.
The interface is inherited from ITreasureSpoke, and the owner() function in TreasurySpoke overrides both the one defined in the IOwnable interface and that of the OwnableUpgradeable module, but calls the module's secure logic to make the interface safe to use and allow the function's effects to be extended to TreasurySpoke and contracts inherited from it.
I preferred to include only the owner() function in IOwnable.sol and not the other functions of the OwnableUpgradeable module because they are important for executable logic and not read-only. However, if different needs arise, I am open to making changes.
The IOwnable.sol file is also designed for all integrations if necessary, not just for TreasurySpoke contract.