Skip to content

style: Add ascii art #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CheyenneAtapour wants to merge 3 commits into
base: main
Choose a base branch
from
Open

style: Add ascii art #1273

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef6ae4c
feat: aave logo art
CheyenneAtapour Mar 17, 2026
870cd53
fix: make symmetric
CheyenneAtapour Mar 17, 2026
0046e60
fix: Move art to spoke instance
CheyenneAtapour Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/hub/Hub.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,35 @@ import {Premium} from 'src/hub/libraries/Premium.sol';
import {IBasicInterestRateStrategy} from 'src/hub/interfaces/IBasicInterestRateStrategy.sol';
import {IHubBase, IHub} from 'src/hub/interfaces/IHub.sol';

// @%%%%%%%%%%%%%%%%%%%%%%%%%%@

@yan-man yan-man Mar 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh i think too big, personally was thinking 20 lines ish (in height)

@CheyenneAtapour CheyenneAtapour Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uniswap's is also 40 lines

@miguelmtzinf miguelmtzinf Mar 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, this is way bigger than expected. I was thinking smt like 10 lines max tbh

@DhairyaSethi DhairyaSethi Mar 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't get anything in 10-20 range tbh

@DhairyaSethi DhairyaSethi Mar 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to me size is fine but these need to be on the instance contracts (which are the entry points of the impl as mentioned before)

// @%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%@
// @%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%@
// @%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%@
// @%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%@
// %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
// %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
// %%%%%%%%%%%%%%%%%%%%%%%%%%%@% %@%%%%%%%%%%%%%%%%%%%%%%%%%%%
// %%%%%%%%%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%%%%%%%%
// @%%%%%%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%%%%%@
// %%%%%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%%%%
// @%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%@
// %%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%
// @%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%@
// %%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%
// @%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%@
// @%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%@
// %%%%%%%%%%%%%%% @%%%%%%%%%%% %%%%%%%%%%%@ %%%%%%%%%%%%%%%
// %%%%%%%%%%%%%%@ %%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%% @%%%%%%%%%%%%%%
// %%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%
// %%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%
// %%%%%%%%%%%%%@ %%%%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%%%% @%%%%%%%%%%%%%
// @%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%@
// %%%%%%%%%%%%%@ %%%%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%%%% @%%%%%%%%%%%%%
// %%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%
// %%%%%%%%%%%%% %%%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%
// %%%%%%%%%%%%% %%%%%%%%%%%%%%% %%%%%%%%%%%%%%% %%%%%%%%%%%%%
// %%%%%%%%%%%%% @%%%%%%%%%%% %%%%%%%%%%%@ %%%%%%%%%%%%%

Comment thread
DhairyaSethi marked this conversation as resolved.
/// @title Hub
/// @author Aave Labs
/// @notice A liquidity hub that manages assets and spokes.
Expand Down
29 changes: 29 additions & 0 deletions src/spoke/Spoke.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,35 @@ import {IHubBase} from 'src/hub/interfaces/IHubBase.sol';
import {ISpoke} from 'src/spoke/interfaces/ISpoke.sol';
import {SpokeStorage} from 'src/spoke/SpokeStorage.sol';

// @%%%%%%%%%%%%%%%%%%%%%%%%%%@

@DhairyaSethi DhairyaSethi Mar 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be on the SpokeInstance instead imo

@DhairyaSethi DhairyaSethi Mar 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make it say v4 probably

@CheyenneAtapour CheyenneAtapour Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved. But yeah maybe we can regenerate more art

// @%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%@
// @%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%@
// @%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%@
// @%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%@
// %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
// %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
// %%%%%%%%%%%%%%%%%%%%%%%%%%%@% %@%%%%%%%%%%%%%%%%%%%%%%%%%%%
// %%%%%%%%%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%%%%%%%%
// @%%%%%%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%%%%%@
// %%%%%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%%%%
// @%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%@
// %%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%
// @%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%@
// %%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%
// @%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%@
// @%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%@
// %%%%%%%%%%%%%%% @%%%%%%%%%%% %%%%%%%%%%%@ %%%%%%%%%%%%%%%
// %%%%%%%%%%%%%%@ %%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%% @%%%%%%%%%%%%%%
// %%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%
// %%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%
// %%%%%%%%%%%%%@ %%%%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%%%% @%%%%%%%%%%%%%
// @%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%@
// %%%%%%%%%%%%%@ %%%%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%%%% @%%%%%%%%%%%%%
// %%%%%%%%%%%%% %%%%%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%
// %%%%%%%%%%%%% %%%%%%%%%%%%%%%%%@ @%%%%%%%%%%%%%%%%% %%%%%%%%%%%%%
// %%%%%%%%%%%%% %%%%%%%%%%%%%%% %%%%%%%%%%%%%%% %%%%%%%%%%%%%
// %%%%%%%%%%%%% @%%%%%%%%%%% %%%%%%%%%%%@ %%%%%%%%%%%%%

Comment thread
DhairyaSethi marked this conversation as resolved.
Outdated
/// @title Spoke
/// @author Aave Labs
/// @notice Handles risk configuration & borrowing strategy for reserves and user positions.
Expand Down
Loading