Skip to content

chore: remove unused code [Y7KC6EG] #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cameronnewman merged 5 commits into from
Aug 25, 2026
Merged

chore: remove unused code [Y7KC6EG] #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7dcac2
[WIP] chore: remove unused code [Y7KC6EG]
Aug 25, 2026
61ad066
chore: record dead-code census plan
Aug 25, 2026
07dda1f
chore: remove unused code
Aug 25, 2026
1119aab
chore: mark plan complete
Aug 25, 2026
7922089
Remove ergates plan file
Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions internal/baseline/baseline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ type Comparison struct {
// TotalLineDropPP is the magnitude of a total line-% drop (>= 0). Zero when
// coverage held or improved, or when a total delta was not computable.
TotalLineDropPP float64
HasTotalLine bool
}

// Compare computes deltas of current versus base.
Expand All @@ -124,7 +123,6 @@ func Compare(current, base *Summary) *Comparison {
if c.Total.HasLine && c.Total.LinePP < 0 {
c.TotalLineDropPP = -c.Total.LinePP
}
c.HasTotalLine = c.Total.HasLine

for id, cur := range current.Workspaces {
baseWS, ok := base.Workspaces[id]
Expand Down
7 changes: 3 additions & 4 deletions internal/render/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ type viewRow struct {
IsTotal bool
IsFolder bool

Tests string // summary rows only ("—" or a number)
HasTests bool
Tests string // summary rows only ("—" or a number)

LinesCovered, LinesValid int
BranchesCovered, BranchesValid int
Expand Down Expand Up @@ -54,7 +53,7 @@ func buildView(s Summary) view {
anyTests = true
}
v.Summary = append(v.Summary, viewRow{
Label: w.DisplayName, Tests: testsCell, HasTests: w.HasTests,
Label: w.DisplayName, Tests: testsCell,
LinesCovered: w.LinesCovered, LinesValid: w.LinesValid,
BranchesCovered: w.BranchesCovered, BranchesValid: w.BranchesValid,
Delta: w.Delta,
Expand Down Expand Up @@ -86,7 +85,7 @@ func buildView(s Summary) view {
totalTests = itoa(tTests)
}
v.Summary = append(v.Summary, viewRow{
Label: "Total", IsTotal: true, Tests: totalTests, HasTests: anyTests,
Label: "Total", IsTotal: true, Tests: totalTests,
LinesCovered: tLC, LinesValid: tLV,
BranchesCovered: tBC, BranchesValid: tBV,
Delta: s.TotalDelta,
Expand Down