Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/halmos/cheatcodes.py
Original file line number Diff line number Diff line change
Expand Up @@ -1379,7 +1379,10 @@ def handle(sevm, ex, arg: ByteVec, stack) -> ByteVec | None:

# explicitly model malleability
recover = f_ecrecover(digest, v, r, s)
recover_malleable = f_ecrecover(digest, v ^ 1, r, secp256k1n - s)
malleable_v = 55 - v # toggle between 27 and 28
recover_malleable = f_ecrecover(
digest, malleable_v, r, secp256k1n - s
)

addr = apply_vmaddr(ex, key)
ex.path.append(recover == addr)
Expand Down
11 changes: 10 additions & 1 deletion tests/regression/test/Signature.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,19 @@ contract SignatureTest is SymTest, Test {
bytes32 digest
) public {
(uint8 v, bytes32 r, bytes32 s) = vm.sign(privateKey, digest);
uint8 malleableV = v == 27 ? 28 : 27;

assert(malleableV == 27 || malleableV == 28);
assertNotEq(v, malleableV);

assertEq(
ecrecover(digest, v, r, s),
ecrecover(digest, v ^ 1, r, bytes32(secp256k1n - uint256(s)))
ecrecover(
digest,
malleableV,
r,
bytes32(secp256k1n - uint256(s))
)
);
}

Expand Down