fix(ai-content-planner): skip empty paragraph insertion when post type has a block template#23401
Open
vraja-pro wants to merge 1 commit into
Conversation
…e has a block template
When a post type registers a block template, insertFirstParagraph would
race against Gutenberg's template application: the effect fired while
blocks was still [] (before the template blocks landed), inserting a
stray core/paragraph at position 0.
The fix reads the template from select('core').getPostType(), which is
populated from the REST API preload cache synchronously before React
renders, unlike getSettings().template which is written by
BlockEditorProvider inside a useEffect (one tick too late).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Coverage Report for CI Build 0Coverage increased (+0.02%) to 53.801%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a post type registers a block template, insertFirstParagraph would race against Gutenberg's template application: the effect fired while blocks was still [] (before the template blocks landed), inserting a stray core/paragraph at position 0.
The fix reads the template from select('core').getPostType(), which is populated from the REST API preload cache synchronously before React renders, unlike getSettings().template which is written by BlockEditorProvider inside a useEffect (one tick too late).
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Setup: Save the following snippet in snippets plugin of functions.php:
With a block template (the bug fix)
core/groupblock and there is no paragraph block under it.Without a block template (regression)
5. Remove or disable the PHP snippet.
6. Create a new post.
7. Confirm the AI Content Planner banner still appears at the top of the empty canvas.
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.[yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached theGoogle Docs Add-onlabel to this PR.Documentation
Quality assurance
grunt build:imagesand committed the results, if my PR introduces or edits images or SVGs.Innovation
innovationlabel.Fixes #23398