chore: Fix return type for Pagination_Helper::get_page_number_from_query_loop()#23383
Open
lonesahilnazir wants to merge 1 commit into
Open
chore: Fix return type for Pagination_Helper::get_page_number_from_query_loop()#23383lonesahilnazir wants to merge 1 commit into
lonesahilnazir wants to merge 1 commit into
Conversation
…loop and add unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Pagination_Helper::get_page_number_from_query_loop()method was documented as returning astring, but it returns anintwhen successfully matching a query loop page, and an emptystringotherwise. This type-annotation mismatch causes static analysis violations (like Psalm/PHPStan) when consuming methods that properly declare anintreturn type pass this value through. This PR fixes the PHPDoc and adds unit tests to strictly pin the expectedint|stringreturn types.Summary
This PR can be summarized in the following changelog entry:
changelog: non-user-facingPagination_Helper::get_page_number_from_query_loop()to reflect its actualint|stringbehavior.Relevant technical choices:
@return int|stringto match what the code actually outputs.test_query_loop_page_number_returns_int_when_above_oneandtest_query_loop_page_number_returns_empty_string_when_absentto pin the runtime behavior, ensuring future clean-ups do not silently change the contract.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
composer test-wp-envor by runningvendor/bin/phpunit tests/Unit/Helpers/Pagination_Helper_Test.php.Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.[yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached theGoogle Docs Add-onlabel to this PR.Documentation
Quality assurance
grunt build:imagesand committed the results, if my PR introduces or edits images or SVGs.Innovation
innovationlabel.Fixes #