-
Notifications
You must be signed in to change notification settings - Fork 964
Decouple the block editor sidebar from the metabox hidden fields #23324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vraja-pro
wants to merge
105
commits into
trunk
Choose a base branch
from
1275-decouple-the-metabox-from-the-block-editor-sidebar
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
105 commits
Select commit
Hold shift + click to select a range
6cbc70e
feat: expose all sidebar-editable post meta fields in the REST API
vraja-pro 1a5e71a
feat: add wpseo_disable_metabox_in_block_editor filter to skip hidden…
vraja-pro 00961c1
feat: route Fields helper reads/writes through core/editor when metab…
vraja-pro 11b670d
feat: use core/editor meta for snippet and score reads/writes when me…
vraja-pro 2ff66d4
feat: sync is_cornerstone from core/editor into yoast-seo/editor
vraja-pro 239f5cf
test: fix and extend useYoastMetaSync and initialize tests for setCor…
vraja-pro fb6d339
refactor: extract meta key strings into camelCase constants to fix ca…
vraja-pro ce731ef
refactor: move meta-key constants to shared-admin/constants/meta-keys.js
vraja-pro f5d16a9
refactor: re-export meta-keys from shared-admin/constants index and u…
vraja-pro 36c68de
refactor: replace inline meta key strings with shared-admin constants…
vraja-pro 05bf66a
fix: wrap long useDispatch.mockReturnValue call to satisfy max-len li…
vraja-pro baa7659
refactor: add schema meta keys to constants file
vraja-pro 209eb6b
fix linting
vraja-pro 6792b23
fix unrelated linting
vraja-pro cad6d57
Merge branch 'trunk' into 1275-decouple-the-metabox-from-the-block-ed…
vraja-pro 0b39e94
fix: align array double arrows in script_data after adding disableMet…
vraja-pro c2b4258
feat: skip add_meta_box entirely when wpseo_disable_metabox_in_block_…
vraja-pro c82633b
fix: support pprimary taxonomy id meta data
vraja-pro a249ebc
refactor: extract helpers from initializePostAnalysis to fix max-stat…
vraja-pro 978060b
fix: guard editPost dispatches in AnalysisFields until editor is ready
vraja-pro 0f0838a
fix: remove object_subtype restriction from REST meta registration
vraja-pro aa8cfea
fix: gate render_hidden_fields() behind is_metabox_disabled_in_block_…
vraja-pro 4175b9b
Fix score persistence when metabox is disabled
vraja-pro 8864bd1
refactor: register all REST-exposed meta in a single register_meta call
vraja-pro 8ae6ee6
fix: set single to true in register_meta for all post meta fields
vraja-pro 24d7611
fix: scope save_postdata REST bail to requests without a metabox nonce
vraja-pro bf32880
revert: restore isLarge prop on ClipboardButton in PrimaryTaxonomyFilter
vraja-pro 5f13afc
fix: queue AnalysisFields meta writes until core/editor is ready
vraja-pro e8b1441
docs: explain why object_subtype is used in register_primary_term_met…
vraja-pro b43cded
refactor: extract PrimaryTermFields helper for primary term meta pers…
vraja-pro 07fe84d
refactor: extract shared isRestMetaActive helper to eliminate duplica…
vraja-pro 3596d35
fix php cs
vraja-pro e54569e
fix: coerce meta values to string in writeOrQueue to pass REST type v…
vraja-pro ec9b973
fix: reflect advanced settings correctly when metabox is disabled in …
vraja-pro c2e6a42
refactor: remove scheduleSettingsSync from AdvancedFields
vraja-pro 95c6358
refactor: remove getLoadableSettings and inline reads into loadAdvanc…
vraja-pro 2b7341a
revert: remove is_cornerstone sync from useYoastMetaSync
vraja-pro 89a9d07
test: remove setCornerstoneContent assertions from useYoastMetaSync t…
vraja-pro cbcc517
cleanup of show_in_rest default
vraja-pro 5709b39
refactor: replace inline disableMetaboxInBlockEditor checks with isRe…
vraja-pro 2c38bf3
fix: defer cornerstone dispatch until core/editor meta is loaded in R…
vraja-pro 7a09e56
fix: prevent duplicate undo entries and score writes from polluting u…
vraja-pro 5a66346
removes comment that is not relevant
vraja-pro 7f177d0
refactor: rename is-rest-meta-active.js to rest-meta.js
vraja-pro 49e4b67
refactor: rename is-rest-meta-active.js to rest-meta.js
vraja-pro b86f05e
fix: exclude estimated reading time from undo stack and register hidd…
vraja-pro 8664c5b
refactor: extract writeMetaWithoutUndo helper and use it for estimate…
vraja-pro 2e7c2bf
refactor: use lodash get in isRestMetaActive for safe nested property…
vraja-pro 932e493
refactor: extract register_meta as a public static method for addon r…
vraja-pro 8513d38
fix: strip all meta keys with the Yoast prefix from unauthorized REST…
vraja-pro df67c4a
refactor: isRestMetaActive shouldn't be a function
vraja-pro 98aaddb
refactor: source isRestMetaActive from the preferences store
vraja-pro 6a58b4e
Revert "refactor: source isRestMetaActive from the preferences store"
vraja-pro 61f8646
refactor: pass field_def to register_meta to control REST API visibility
vraja-pro 9e17158
fix: add traversable type hint to register_meta field_def param
vraja-pro ed8ae36
fix: php cs
vraja-pro 7bb0ff0
fix: remove duplicate field
vraja-pro b01800a
fix: hide post meta from REST for all post types
vraja-pro af0d6d3
fix: register primary term meta on init so CPT taxonomies are available
vraja-pro 0bbfeb3
fix: coerce imageId to string before dispatching to REST meta
vraja-pro 1936004
refactor: centralize REST meta read/write into getMetaValue/setMetaVa…
vraja-pro f54137b
fix: invert setMetaValue undo param to withoutUndo for clearer default
vraja-pro 83ec10e
refactor: move SchemaFields into helpers/fields and use getMetaValue/…
vraja-pro 2b0833f
fix: correct stale @param name in setMetaValue JSDoc
vraja-pro ca48fec
fix: use isRestMetaActive instead of re-reading wpseoScriptData in po…
vraja-pro a22f938
fix: remove redundant optional chaining in PrimaryTermFields.getIniti…
vraja-pro e578764
fix: explain direct filter call and return false in save_postdata bail
vraja-pro 0741cb3
refactor: unexport readMeta and writeMeta as they are internal helpers
vraja-pro e08174a
fix: correct deprecated version to 28.0 in Estimated_Reading_Time
vraja-pro 61c2236
test: add unit tests for rest-meta helpers and PrimaryTermFields
vraja-pro b2e2ff1
refactor: use meta key constants in rest-meta tests
vraja-pro 1039044
test: add unit tests for all helpers/fields classes
vraja-pro 626f75e
fix: register primary term meta in fields_index and defaults to fix s…
vraja-pro 3edba17
fix: register estimated reading time field via add_extra_wpseo_meta_f…
vraja-pro d5f17ca
fix: php cs
vraja-pro f34a605
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into 1275-deco…
FAMarfuaty fa49fed
fix: fix saving of advanced settings
vraja-pro 03f3541
fix: move schema defaults and showArticleInput flag to wpseoScriptData
vraja-pro 2083ee7
fix primary term save
vraja-pro afc017b
fix: tests for helpers fields
vraja-pro 8c5b1c3
fix: separate rest registration and cleanup wpseo meta and added a c…
vraja-pro 4c008b4
fix: defer initial keyphrase load in REST meta mode until entity meta…
vraja-pro d964ac6
fix: ensure CPTs expose meta in REST API by adding custom-fields support
vraja-pro 258ccab
fix: guard schema_page_type access when get_meta_field_defs returns e…
vraja-pro 93d473a
fix: restore unauthorized REST read filter and fix stale JSDoc
vraja-pro ad93352
fix: fire wpseo_saved_postdata after REST API post update when metabo…
vraja-pro c8044ee
tests: add unit tests for Post_Meta_Rest_Fields
vraja-pro 30f19bb
fix: consolidate REST meta boot-time deferral into one subscriber
vraja-pro 690dc99
fix: remove unused this.input assignment in PrimaryTaxonomyPicker
vraja-pro c578cef
fix: cleanup unused prop
vraja-pro c6480bf
fix: preserve undoIgnore flag for queued meta writes in AnalysisFields
vraja-pro c47f239
refactor: route PostDataCollector field access through AnalysisFields…
vraja-pro 20a0b83
tests: add REST meta and pending-write flush coverage for field helpers
vraja-pro 8854e29
refactor: extract initializeSnippetEditorSync to snippet-editor-sync.js
vraja-pro af484bc
refactor: move snippet-editor-sync from initializers to helpers
vraja-pro 38e6a9c
refactor: extract post-scraper sub-steps into initializers/post-scraper/
vraja-pro 799eaad
tests: drop redundant description REST meta mode tests
vraja-pro 3ec4daa
fix: initializeSnippetEditorSync imports
vraja-pro 81483df
restore refactor
vraja-pro 9de6f06
refactor: inline initializeSnippetEditorSync, extract dispatchInitial…
vraja-pro 5a6f161
restore refactor to avoid scoop creep
vraja-pro 24ae9e6
fix: gate add_post_type_support behind filter and block editor check
vraja-pro 495db0b
fix: add wpseo_edit_advanced_metadata cap check to advanced/schema fi…
vraja-pro ed540a8
tests: replace unit tests with WP integration tests for Post_Meta_Res…
vraja-pro 7230c9b
fix: removes default value from rest registration
vraja-pro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I moved the REST registration of the meta data to an initializer class.
Keeping the regular register meta doesn't harm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FAMarfuaty marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.