Conversation
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
docs(exception): add comment for updating exit code doc
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
# Conflicts: # docs/contributing.md # docs/contributing_tldr.md # poetry.lock # pyproject.toml
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def get(self, document: TOMLDocument) -> str: | ||
| out = _try_get_workspace(document)["package"]["version"] | ||
| if TYPE_CHECKING: | ||
| assert isinstance(out, str) | ||
| return out | ||
|
|
||
| def set(self, document: tomlkit.TOMLDocument, version: str) -> None: | ||
| try: | ||
| document["workspace"]["package"]["version"] = version # type: ignore[index] | ||
| return | ||
| except tomlkit.exceptions.NonExistentKey: | ||
| ... | ||
| document["package"]["version"] = version # type: ignore[index] | ||
| def set(self, document: TOMLDocument, version: str) -> None: | ||
| _try_get_workspace(document)["package"]["version"] = version |
There was a problem hiding this comment.
The cargo provider now always indexes workspace["package"]["version"], ignoring a top-level [package] section when a [workspace] table is present. In a common layout where the root crate declares its version under [package] but the workspace has no [workspace.package], this call raises NonExistentKey and cz bump/get_version aborts. The previous logic fell back to the package version before touching workspace state. Please restore the fallback to [package].version so workspaces without workspace.package continue to work.
Useful? React with 👍 / 👎.
6 participants
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context