Skip to content

fix: Assert connection is loaded in PeerReservationTable mutators #7828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 4 commits into
base: develop
Choose a base branch
from
+5 −0
Open

fix: Assert connection is loaded in PeerReservationTable mutators #7828

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0712c7c
fix: Assert connection is loaded in PeerReservationTable mutators
SAY-5 Jul 18, 2026
64a4465
Merge branch 'develop' into ci/peer-reservation-null-connection-guard
SAY-5 Jul 20, 2026
e1e1d92
Merge branch 'develop' into ci/peer-reservation-null-connection-guard
SAY-5 Jul 22, 2026
46764b5
Merge branch 'develop' into ci/peer-reservation-null-connection-guard
SAY-5 Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/xrpld/overlay/detail/PeerReservationTable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include <xrpl/core/PeerReservationTable.h>

#include <xrpl/beast/utility/instrumentation.h>
#include <xrpl/json/json_value.h>
#include <xrpl/protocol/PublicKey.h>
#include <xrpl/protocol/jss.h>
Expand Down Expand Up @@ -62,6 +63,8 @@ PeerReservationTable::load(DatabaseCon& connection)
std::optional<PeerReservation>
PeerReservationTable::insertOrAssign(PeerReservation const& reservation)
{
XRPL_ASSERT(connection_, "xrpl::PeerReservationTable::insertOrAssign : connection is set");

std::optional<PeerReservation> previous;

std::scoped_lock const lock(mutex_);
Expand Down Expand Up @@ -96,6 +99,8 @@ PeerReservationTable::insertOrAssign(PeerReservation const& reservation)
std::optional<PeerReservation>
PeerReservationTable::erase(PublicKey const& nodeId)
{
XRPL_ASSERT(connection_, "xrpl::PeerReservationTable::erase : connection is set");

std::optional<PeerReservation> previous;

std::scoped_lock const lock(mutex_);
Expand Down
Loading