(master) xquartz: parentheses around macro argument symbols#2941
Open
metux wants to merge 1 commit into
Open
Conversation
metux
added a commit
that referenced
this pull request
Jun 9, 2026
metux
added a commit
that referenced
this pull request
Jun 9, 2026
metux
added a commit
that referenced
this pull request
Jun 9, 2026
metux
added a commit
that referenced
this pull request
Jun 9, 2026
Contributor
Author
|
Closing to re-trigger CI |
For safety, add extra parantheses on each used macro argument. In most cases not strictly necessary, but better have some strict and automatically enforcable policy here than wasting time on judging individual cases. Exception: the token pasting operator ## cannot be used with parenthesized arguments, so X_PFX is left unchanged. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
metux
force-pushed
the
pr/master-xquartz-parentheses-around-macro-argument-symbols-_2026-06-09_13-59-27
branch
from
a634c2e to
1f1a9e8
Compare
metux
added a commit
that referenced
this pull request
Jun 10, 2026
For safety, add extra parantheses on each used macro argument. In most cases not strictly necessary, but better have some strict and automatically enforcable policy here than wasting time on judging individual cases. Exception: the token pasting operator ## cannot be used with parenthesized arguments, so X_PFX is left unchanged. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
metux
added a commit
that referenced
this pull request
Jun 10, 2026
For safety, add extra parantheses on each used macro argument. In most cases not strictly necessary, but better have some strict and automatically enforcable policy here than wasting time on judging individual cases. Exception: the token pasting operator ## cannot be used with parenthesized arguments, so X_PFX is left unchanged. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For safety, add extra parantheses on each used macro argument.
In most cases not strictly necessary, but better have some strict
and automatically enforcable policy here than wasting time on
judging individual cases.
Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net