Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 57 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mho22
force-pushed
the
compile-php-wasm-node-and-web
branch
from
d0cf1ed to
0ce3185
Compare
mho22
changed the title
mho22
changed the title
mho22
force-pushed
the
compile-php-wasm-node-and-web
branch
2 times, most recently
from
2243029 to
127ebe0
Compare
Member
|
@mho22 The CI is not getting green. I tried to rerun the failing job, but no luck. Do you happen to know what could be the issue? |
Collaborator
Author
|
@JanJakes Yes, and the fix is in this pull request that is why I am silently waiting before merging this one. Is it preferable to draft this PR? |
Member
|
@mho22 Oh, if the failure is unrelated, then let's merge? |
JanJakes
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is part of #3512
Compiling PHP.wasm Node.
This is the second attempt since the first one was merged directly inside #3512 which hit the same issue as when you recompile PHP.wasm directly inside a PR.
And it looks like even this is not possible. We will probably need to Compile Node and Web separately.