Skip to content

[PHP] Add TSRMLS_CC fallback defines for PHP versions above 7 #3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mho22 merged 2 commits into from
Apr 22, 2026
+12 −2
Merged

[PHP] Add TSRMLS_CC fallback defines for PHP versions above 7 #3512

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
222d633
Add TSRMLS_CC fallback defines for PHP 7+ in dns_polyfill and post_me…
mho22 Apr 20, 2026
ef5eb71
Keep consistency with ZEND_FE_END
mho22 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/php-wasm/compile/php-post-message-to-js/post_message_to_js.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
#define PHP_FE_END {NULL, NULL, NULL}
#endif

/* TSRMLS macros were removed in PHP 7; provide empty fallbacks */
#if !defined(TSRMLS_CC)
Comment thread
mho22 marked this conversation as resolved.
Outdated
#define TSRMLS_CC
#endif
Comment thread
mho22 marked this conversation as resolved.
Outdated

/**
* Provided by php_wasm.c:
*/
Expand Down Expand Up @@ -83,4 +88,4 @@ zend_module_entry post_message_to_js_module_entry = {
ZEND_TSRMLS_CACHE_DEFINE()
#endif
ZEND_GET_MODULE(post_message_to_js)
#endif
#endif
7 changes: 6 additions & 1 deletion packages/php-wasm/compile/php-wasm-dns-polyfill/dns_polyfill.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
#define ZEND_FE_END {NULL, NULL, NULL}
#endif

/* TSRMLS macros were removed in PHP 7; provide empty fallbacks */
#if !defined(TSRMLS_CC)
#define TSRMLS_CC
#endif
Comment thread
mho22 marked this conversation as resolved.

#ifdef HAVE_SYS_SOCKET_H
#include <sys/socket.h>
#endif
Expand Down Expand Up @@ -329,4 +334,4 @@ zend_module_entry dns_polyfill_module_entry = {
PHP_MINFO(dns_polyfill), /* PHP_MINFO - Module info */
PHP_DNS_POLYFILL_VERSION, /* Version */
STANDARD_MODULE_PROPERTIES};
/* }}} */
/* }}} */
Loading