[GitHub Actions] Fix GitHub release missing changelog#3502
Merged
Conversation
…ELOG.md instead of Release NPM packages
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts the GitHub Release publishing workflow trigger so it runs after the changelog has been generated/committed, preventing releases with empty/missing changelog content.
Changes:
- Update
publish-github-release.ymlto trigger onUpdate CHANGELOG.mdworkflow completion (instead ofRelease NPM packages) - Enforce a sequential workflow chain: release → changelog update → GitHub release publish
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
Collaborator
Author
|
@brandonpayton Manually running the |
Collaborator
|
Let's give it a try! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation for the change, related issues
Follow-up on #3488
The
Publish GitHub ReleaseandUpdate CHANGELOG.mdworkflows both trigger onRelease NPM packagescompletion, so they run in parallel. This means the GitHub release readsCHANGELOG.mdbefore it's been updated, resulting in releases with no changelog.Implementation details
Changed
publish-github-release.ymlto trigger onUpdate CHANGELOG.mdcompletion instead ofRelease NPM packagescompletion. This ensures the workflow chain is sequential:Release NPM packagescompletesUpdate CHANGELOG.mdtriggers, generates and commits the changelogPublish GitHub Releasetriggers, reads the now-updatedCHANGELOG.mdTesting Instructions (or ideally a Blueprint)
Release NPM packagesworkflow manually.Update CHANGELOG.mdto complete.Publish GitHub Releasetriggers afterUpdate CHANGELOG.mdnot afterRelease NPM packages.