Skip to content

[GitHub Actions] Fix GitHub release missing changelog#3502

Merged
adamziel merged 1 commit intotrunkfrom
publish-github-release-after-changelog
Apr 27, 2026
Merged

[GitHub Actions] Fix GitHub release missing changelog#3502
adamziel merged 1 commit intotrunkfrom
publish-github-release-after-changelog

Conversation

@mho22
Copy link
Copy Markdown
Collaborator

@mho22 mho22 commented Apr 16, 2026

Motivation for the change, related issues

Follow-up on #3488

The Publish GitHub Release and Update CHANGELOG.md workflows both trigger on Release NPM packages completion, so they run in parallel. This means the GitHub release reads CHANGELOG.md before it's been updated, resulting in releases with no changelog.

Implementation details

Changed publish-github-release.yml to trigger on Update CHANGELOG.md completion instead of Release NPM packages completion. This ensures the workflow chain is sequential:

  1. Release NPM packages completes
  2. Update CHANGELOG.md triggers, generates and commits the changelog
  3. Publish GitHub Release triggers, reads the now-updated CHANGELOG.md

Testing Instructions (or ideally a Blueprint)

  1. Trigger the Release NPM packages workflow manually.
  2. Wait for Update CHANGELOG.md to complete.
  3. Verify Publish GitHub Release triggers after Update CHANGELOG.md not after Release NPM packages.
  4. Confirm the GitHub release body contains the actual changelog entries instead of "No changelog entries for this release."

@mho22 mho22 requested a review from a team April 16, 2026 16:37
@mho22 mho22 added the [Type] Bug An existing feature does not function as intended label Apr 16, 2026
@mho22 mho22 requested a review from bgrgicak April 16, 2026 16:37
Copilot AI review requested due to automatic review settings April 16, 2026 16:37
@mho22 mho22 requested review from brandonpayton and removed request for bgrgicak April 16, 2026 16:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adjusts the GitHub Release publishing workflow trigger so it runs after the changelog has been generated/committed, preventing releases with empty/missing changelog content.

Changes:

  • Update publish-github-release.yml to trigger on Update CHANGELOG.md workflow completion (instead of Release NPM packages)
  • Enforce a sequential workflow chain: release → changelog update → GitHub release publish

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/publish-github-release.yml
@mho22
Copy link
Copy Markdown
Collaborator Author

mho22 commented Apr 16, 2026

I should have been more careful about this :

Capture d’écran 2026-04-16 à 18 38 15

"No changelog entries for this release." :

Capture d’écran 2026-04-16 à 18 38 29

@mho22
Copy link
Copy Markdown
Collaborator Author

mho22 commented Apr 21, 2026

@brandonpayton Manually running the Update CHANGELOG.md action will trigger the Publish Github Release but if there's no new NPM release it will be skipped. But in a way, it can be interesting to run Update CHANGELOG.md manually and update the Github release with the next version if it doesn't exist yet.

@adamziel adamziel merged commit faa8306 into trunk Apr 27, 2026
47 checks passed
@adamziel adamziel deleted the publish-github-release-after-changelog branch April 27, 2026 19:32
@adamziel
Copy link
Copy Markdown
Collaborator

Let's give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] GitHub integration [Type] Bug An existing feature does not function as intended [Type] Developer Experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants