[PHP] Fix MEMFS symlink crash during PHP runtime rotation#3500
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes a crash during PHP runtime rotation when copying MEMFS nodes that include directory symlinks, by preserving symlinks instead of incorrectly treating them as real directories.
Changes:
- Update MEMFS copy logic to detect symlinks via
lookupPath(..., { follow: false })and recreate them withsymlink(). - Add a regression test ensuring MEMFS symlinks and subsequent entries survive runtime rotation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/php-wasm/universal/src/lib/php.ts | Prevents symlink-to-directory from being followed during MEMFS copy; recreates symlink in target FS. |
| packages/php-wasm/node/src/test/rotate-php-runtime.spec.ts | Adds a test covering symlink preservation across runtime recreation/rotation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
copyMEMFSNodescrashes when it encounters a symlink to a directory during PHP runtime rotation. This happens because lookupPath defaults to{ follow: true }, which resolves the symlink and treats it as a regular directory, leading to incorrect copying and crashes.Implementation details
In
copyMEMFSNodes, use lookupPath with{ follow: false }to detect symlinks before following them. When a symlink is found, recreate it viasymlink()instead of attempting to copy the target's contents.Testing Instructions (or ideally a Blueprint)
CI