-
Notifications
You must be signed in to change notification settings - Fork 414
CLI: Set PLAYGROUND_AUTO_LOGIN_AS_USER at boot time for all workers when --login is used #3485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ashfame
wants to merge
5
commits into
trunk
Choose a base branch
from
fix/cli-login-constant-all-workers
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a265316
Inject PLAYGROUND_AUTO_LOGIN_AS_USER in mergeDefinedConstants when --…
ashfame 53baaed
Pass CLI-defined constants to each V1 worker via bootRequestHandler
ashfame ffc75c5
Add tests for mergeDefinedConstants login constant injection
ashfame c999884
Remove resolved TODO and fix mu-plugin filename in login step docstring
ashfame 2827524
Skip blueprint login step when PLAYGROUND_AUTO_LOGIN_AS_USER is set v…
ashfame File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
packages/playground/cli/tests/merge-defined-constants.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import { mergeDefinedConstants } from '../src/defines'; | ||
|
|
||
| describe('mergeDefinedConstants', () => { | ||
| it('should merge string, boolean, and number constants', () => { | ||
| const result = mergeDefinedConstants({ | ||
| define: { API_KEY: 'secret' }, | ||
| 'define-bool': { WP_DEBUG: true }, | ||
| 'define-number': { LIMIT: 100 }, | ||
| }); | ||
| expect(result).toEqual({ | ||
| API_KEY: 'secret', | ||
| WP_DEBUG: true, | ||
| LIMIT: 100, | ||
| }); | ||
| }); | ||
|
|
||
| it('should return empty object when no constants are provided', () => { | ||
| const result = mergeDefinedConstants({}); | ||
| expect(result).toEqual({}); | ||
| }); | ||
|
|
||
| it('should inject PLAYGROUND_AUTO_LOGIN_AS_USER when login is true', () => { | ||
| const result = mergeDefinedConstants({ login: true }); | ||
| expect(result).toEqual({ | ||
| PLAYGROUND_AUTO_LOGIN_AS_USER: 'admin', | ||
| }); | ||
| }); | ||
|
|
||
| it('should not inject login constant when login is false', () => { | ||
| const result = mergeDefinedConstants({ login: false }); | ||
| expect(result).toEqual({}); | ||
| }); | ||
|
|
||
| it('should not inject login constant when login is undefined', () => { | ||
| const result = mergeDefinedConstants({}); | ||
| expect(result).toEqual({}); | ||
| }); | ||
|
|
||
| it('should not override explicit PLAYGROUND_AUTO_LOGIN_AS_USER from --define', () => { | ||
| const result = mergeDefinedConstants({ | ||
| define: { PLAYGROUND_AUTO_LOGIN_AS_USER: 'editor' }, | ||
| login: true, | ||
| }); | ||
| expect(result).toEqual({ | ||
| PLAYGROUND_AUTO_LOGIN_AS_USER: 'editor', | ||
| }); | ||
| }); | ||
|
|
||
| it('should preserve other constants alongside the injected login constant', () => { | ||
| const result = mergeDefinedConstants({ | ||
| define: { API_KEY: 'secret' }, | ||
| 'define-bool': { WP_DEBUG: true }, | ||
| login: true, | ||
| }); | ||
| expect(result).toEqual({ | ||
| API_KEY: 'secret', | ||
| WP_DEBUG: true, | ||
| PLAYGROUND_AUTO_LOGIN_AS_USER: 'admin', | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.